Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: Source/core/rendering/RenderDeprecatedFlexibleBox.h

Issue 154343002: Devirtualize isStretchingChildren (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix Debug ASSERT Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of the render object implementation for KHTML. 2 * This file is part of the render object implementation for KHTML.
3 * 3 *
4 * Copyright (C) 2003 Apple Computer, Inc. 4 * Copyright (C) 2003 Apple Computer, Inc.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 28 matching lines...) Expand all
39 virtual const char* renderName() const OVERRIDE; 39 virtual const char* renderName() const OVERRIDE;
40 40
41 virtual void styleWillChange(StyleDifference, const RenderStyle* newStyle) O VERRIDE; 41 virtual void styleWillChange(StyleDifference, const RenderStyle* newStyle) O VERRIDE;
42 42
43 virtual void layoutBlock(bool relayoutChildren) OVERRIDE; 43 virtual void layoutBlock(bool relayoutChildren) OVERRIDE;
44 void layoutHorizontalBox(bool relayoutChildren); 44 void layoutHorizontalBox(bool relayoutChildren);
45 void layoutVerticalBox(bool relayoutChildren); 45 void layoutVerticalBox(bool relayoutChildren);
46 46
47 virtual bool avoidsFloats() const OVERRIDE { return true; } 47 virtual bool avoidsFloats() const OVERRIDE { return true; }
48 virtual bool isDeprecatedFlexibleBox() const OVERRIDE { return true; } 48 virtual bool isDeprecatedFlexibleBox() const OVERRIDE { return true; }
49 virtual bool isStretchingChildren() const OVERRIDE { return m_stretchingChil dren; } 49 bool isStretchingChildren() const { return m_stretchingChildren; }
50 virtual bool canCollapseAnonymousBlockChild() const OVERRIDE { return false; } 50 virtual bool canCollapseAnonymousBlockChild() const OVERRIDE { return false; }
51 51
52 void placeChild(RenderBox* child, const LayoutPoint& location); 52 void placeChild(RenderBox* child, const LayoutPoint& location);
53 53
54 protected: 54 protected:
55 virtual void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, Layo utUnit& maxLogicalWidth) const OVERRIDE; 55 virtual void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, Layo utUnit& maxLogicalWidth) const OVERRIDE;
56 virtual void computePreferredLogicalWidths() OVERRIDE; 56 virtual void computePreferredLogicalWidths() OVERRIDE;
57 57
58 LayoutUnit allowedChildFlex(RenderBox* child, bool expanding, unsigned group ); 58 LayoutUnit allowedChildFlex(RenderBox* child, bool expanding, unsigned group );
59 59
60 bool hasMultipleLines() const { return style()->boxLines() == MULTIPLE; } 60 bool hasMultipleLines() const { return style()->boxLines() == MULTIPLE; }
61 bool isVertical() const { return style()->boxOrient() == VERTICAL; } 61 bool isVertical() const { return style()->boxOrient() == VERTICAL; }
62 bool isHorizontal() const { return style()->boxOrient() == HORIZONTAL; } 62 bool isHorizontal() const { return style()->boxOrient() == HORIZONTAL; }
63 63
64 bool m_stretchingChildren; 64 bool m_stretchingChildren;
65 65
66 private: 66 private:
67 virtual bool supportsPartialLayout() const OVERRIDE { return false; } 67 virtual bool supportsPartialLayout() const OVERRIDE { return false; }
68 68
69 void applyLineClamp(FlexBoxIterator&, bool relayoutChildren); 69 void applyLineClamp(FlexBoxIterator&, bool relayoutChildren);
70 void clearLineClamp(); 70 void clearLineClamp();
71 }; 71 };
72 72
73 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderDeprecatedFlexibleBox, isDeprecatedFlexibl eBox());
74
73 } // namespace WebCore 75 } // namespace WebCore
74 76
75 #endif // RenderDeprecatedFlexibleBox_h 77 #endif // RenderDeprecatedFlexibleBox_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698