Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1543413002: Remove CPDF_Creator::m_ObjectSize, it's never read from. (Closed)

Created:
4 years, 12 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove CPDF_Creator::m_ObjectSize, it's never read from. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/03f5040cbe03cc93e133cb98ecce6725e2679170

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M core/include/fpdfapi/fpdf_serial.h View 1 chunk +1 line, -5 lines 0 comments Download
M core/include/fxcrt/fx_basic.h View 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 9 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
4 years, 11 months ago (2016-01-04 19:53:08 UTC) #2
Tom Sepez
lgtm
4 years, 11 months ago (2016-01-04 20:45:49 UTC) #3
Lei Zhang
4 years, 11 months ago (2016-01-04 22:14:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
03f5040cbe03cc93e133cb98ecce6725e2679170 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698