Remove CPDF_Creator::m_ObjectSize, it's never read from.

core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "editint.h"
 
 #include "core/include/fxcrt/fx_ext.h"
 #include "core/include/fpdfapi/fpdf_serial.h"
@@ skipping 636 matching lines @@
           _AppendIndex1(m_Buffer, *offset);
         } else {
           _AppendIndex2(m_Buffer, dwObjStmNum, index++);
         }
       } else {
         _AppendIndex0(m_Buffer, FALSE);
       }
     }
     if (iSize > 0 && bEOF) {
       pCreator->m_ObjectOffset.Add(dwObjStmNum, 1);
-      pCreator->m_ObjectSize.Add(dwObjStmNum, 1);
       pCreator->m_ObjectOffset[dwObjStmNum] = objOffset;
     }
     m_iSeg = iSeg;
     if (bEOF) {
       m_ObjStream.Start();
     }
     return 1;
   }
   int32_t& j = m_ObjStream.m_index;
   for (int i = m_iSeg; i < iSeg; i++) {
@@ skipping 590 matching lines @@
   void* valuetemp = NULL;
   FX_BOOL bExistInMap =
       m_pDocument->m_IndirectObjs.Lookup((void*)(uintptr_t)objnum, valuetemp);
   FX_BOOL bObjStm =
       (m_pParser->m_V5Type[objnum] == 2) && m_pEncryptDict && !m_pXRefStream;
   if (m_pParser->m_bVersionUpdated || m_bSecurityChanged || bExistInMap ||
       bObjStm) {
     CPDF_Object* pObj = m_pDocument->GetIndirectObject(objnum);
     if (!pObj) {
       m_ObjectOffset[objnum] = 0;
-      m_ObjectSize[objnum] = 0;
       return 0;
     }
     if (WriteIndirectObj(pObj)) {
       return -1;
     }
     if (!bExistInMap) {
       m_pDocument->ReleaseIndirectObject(objnum);
     }
   } else {
     uint8_t* pBuffer;
@@ skipping 46 matching lines @@
 
   FX_DWORD objnum = (FX_DWORD)(uintptr_t)m_Pos;
   for (; objnum <= nLastObjNum; ++objnum) {
     int32_t iRet = WriteOldIndirectObject(objnum);
     if (iRet < 0)
       return iRet;
 
     if (!iRet)
       continue;
 
-    m_ObjectSize[objnum] = (FX_DWORD)(m_Offset - m_ObjectOffset[objnum]);
     if (pPause && pPause->NeedToPauseNow()) {
       m_Pos = (void*)(uintptr_t)(objnum + 1);
       return 1;
     }
   }
   return 0;
 }
 int32_t CPDF_Creator::WriteNewObjs(FX_BOOL bIncremental, IFX_Pause* pPause) {
   int32_t iCount = m_NewObjNumArray.GetSize();
   int32_t index = (int32_t)(uintptr_t)m_Pos;
   while (index < iCount) {
     FX_DWORD objnum = m_NewObjNumArray.ElementAt(index);
     CPDF_Object* pObj = NULL;
     m_pDocument->m_IndirectObjs.Lookup((void*)(uintptr_t)objnum, (void*&)pObj);
     if (NULL == pObj) {
       ++index;
       continue;
     }
     m_ObjectOffset[objnum] = m_Offset;
     if (WriteIndirectObj(pObj)) {
       return -1;
     }
-    m_ObjectSize[objnum] = (FX_DWORD)(m_Offset - m_ObjectOffset[objnum]);
     index++;
     if (pPause && pPause->NeedToPauseNow()) {
       m_Pos = (FX_POSITION)(uintptr_t)index;
       return 1;
     }
   }
   return 0;
 }
 void CPDF_Creator::InitOldObjNumOffsets() {
   if (!m_pParser) {
     return;
   }
   FX_DWORD j = 0;
   FX_DWORD dwStart = 0;
   FX_DWORD dwEnd = m_pParser->GetLastObjNum();
   while (dwStart <= dwEnd) {
     while (dwStart <= dwEnd && (m_pParser->m_V5Type[dwStart] == 0 ||
                                 m_pParser->m_V5Type[dwStart] == 255)) {
       dwStart++;
     }
     if (dwStart > dwEnd) {
       break;
     }
     j = dwStart;
     while (j <= dwEnd && m_pParser->m_V5Type[j] != 0 &&
            m_pParser->m_V5Type[j] != 255) {
       j++;
     }
     m_ObjectOffset.Add(dwStart, j - dwStart);
-    m_ObjectSize.Add(dwStart, j - dwStart);
     dwStart = j;
   }
 }
 void CPDF_Creator::InitNewObjNumOffsets() {
   FX_BOOL bIncremental = (m_dwFlags & FPDFCREATE_INCREMENTAL) != 0;
   FX_BOOL bNoOriginal = (m_dwFlags & FPDFCREATE_NO_ORIGINAL) != 0;
   FX_POSITION pos = m_pDocument->m_IndirectObjs.GetStartPosition();
   while (pos) {
     size_t key = 0;
     CPDF_Object* pObj;
@@ skipping 31 matching lines @@
     return;
   }
   FX_DWORD dwLastObjNum = dwStartObjNum;
   i++;
   FX_BOOL bNewStart = FALSE;
   for (; i < iCount; i++) {
     FX_DWORD dwCurObjNum = m_NewObjNumArray.ElementAt(i);
     bool bExist = m_pParser && m_pParser->IsValidObjectNumber(dwCurObjNum) &&
                   m_ObjectOffset.GetPtrAt(dwCurObjNum);
     if (bExist || dwCurObjNum - dwLastObjNum > 1) {
-      if (!bNewStart) {
+      if (!bNewStart)
         m_ObjectOffset.Add(dwStartObjNum, dwLastObjNum - dwStartObjNum + 1);
-        m_ObjectSize.Add(dwStartObjNum, dwLastObjNum - dwStartObjNum + 1);
-      }
       dwStartObjNum = dwCurObjNum;
     }
     if (bNewStart) {
       dwStartObjNum = dwCurObjNum;
     }
     bNewStart = bExist;
     dwLastObjNum = dwCurObjNum;
   }
   m_ObjectOffset.Add(dwStartObjNum, dwLastObjNum - dwStartObjNum + 1);
-  m_ObjectSize.Add(dwStartObjNum, dwLastObjNum - dwStartObjNum + 1);
 }
 void CPDF_Creator::AppendNewObjNum(FX_DWORD objbum) {
   int32_t iStart = 0, iFind = 0;
   int32_t iEnd = m_NewObjNumArray.GetUpperBound();
   while (iStart <= iEnd) {
     int32_t iMid = (iStart + iEnd) / 2;
     FX_DWORD dwMid = m_NewObjNumArray.ElementAt(iMid);
     if (objbum < dwMid) {
       iEnd = iMid - 1;
     } else {
@@ skipping 138 matching lines @@
   }
   if (m_iStage == 27) {
     if (NULL != m_pEncryptDict && 0 == m_pEncryptDict->GetObjNum()) {
       m_dwLastObjNum += 1;
       FX_FILESIZE saveOffset = m_Offset;
       if (WriteIndirectObj(m_dwLastObjNum, m_pEncryptDict) < 0) {
         return -1;
       }
       m_ObjectOffset.Add(m_dwLastObjNum, 1);
       m_ObjectOffset[m_dwLastObjNum] = saveOffset;
-      m_ObjectSize.Add(m_dwLastObjNum, 1);
-      m_ObjectSize[m_dwLastObjNum] = m_Offset - saveOffset;
       m_dwEnryptObjNum = m_dwLastObjNum;
       if (m_dwFlags & FPDFCREATE_INCREMENTAL) {
         m_NewObjNumArray.Add(m_dwLastObjNum);
       }
     }
     m_iStage = 80;
   }
   return m_iStage;
 }
 int32_t CPDF_Creator::WriteDoc_Stage3(IFX_Pause* pPause) {
@@ skipping 367 matching lines @@
     return FALSE;
   }
   return Create(flags);
 }
 FX_BOOL CPDF_Creator::Create(FX_DWORD flags) {
   m_dwFlags = flags;
   m_iStage = 0;
   m_Offset = 0;
   m_dwLastObjNum = m_pDocument->GetLastObjNum();
   m_ObjectOffset.Clear();
-  m_ObjectSize.Clear();
   m_NewObjNumArray.RemoveAll();
   InitID();
   if (flags & FPDFCREATE_PROGRESSIVE) {
     return TRUE;
   }
   return Continue(NULL) > -1;
 }
 void CPDF_Creator::InitID(FX_BOOL bDefault) {
   CPDF_Array* pOldIDArray = m_pParser ? m_pParser->GetIDArray() : NULL;
   FX_BOOL bNewId = !m_pIDArray;
@@ skipping 92 matching lines @@
   m_bNewCrypto = FALSE;
   if (!m_bStandardSecurity) {
     return;
   }
   if (m_pEncryptDict) {
     m_pEncryptDict->Release();
     m_pEncryptDict = NULL;
   }
   m_bStandardSecurity = FALSE;
 }