Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1543173002: Switch to standard integer types in ui/views/. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
Reviewers:
Nico, sky
CC:
chromium-reviews, shuchen+watch_chromium.org, tdanderson+views_chromium.org, msw+watch_chromium.org, hcarmona+bubble_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, groby+bubble_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, nona+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, dcheng, James Su, rouslan+bubble_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in ui/views/. BUG=138542 TBR=sky@chromium.org Committed: https://crrev.com/fba04a5abfa4c7740abb03ecb160802e5e66a811 Cr-Commit-Position: refs/heads/master@{#366723}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+627 lines, -163 lines) Patch
M ui/views/accessibility/ax_aura_obj_cache.h View 4 chunks +23 lines, -18 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.cc View 7 chunks +20 lines, -15 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_wrapper.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/views/accessibility/ax_view_obj_wrapper.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/views/accessibility/ax_view_obj_wrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/accessibility/ax_widget_obj_wrapper.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/views/accessibility/ax_widget_obj_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/accessibility/ax_window_obj_wrapper.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/views/accessibility/ax_window_obj_wrapper.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/accessibility/native_view_accessibility.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_auralinux.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_auralinux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/accessible_pane_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/accessible_pane_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/accessible_pane_view_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/animation/bounds_animator.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/animation/bounds_animator_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/animation/scroll_animator.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/test/ink_drop_animation_test_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/background.h View 1 chunk +5 lines, -4 lines 0 comments Download
M ui/views/background.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/border.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/border.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/bubble/bubble_border.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/bubble_border_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/bubble/bubble_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/bubble/bubble_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/bubble/bubble_delegate_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/bubble_frame_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/bubble/bubble_frame_view_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/bubble/bubble_window_targeter.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/bubble/bubble_window_targeter_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/bubble/tray_bubble_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/bubble/tray_bubble_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/cocoa/bridged_native_widget.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget_interactive_uitest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/cocoa/bridged_native_widget_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/cocoa/cocoa_mouse_capture.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/cocoa/cocoa_mouse_capture_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/cocoa/widget_owner_nswindow_adapter.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/color_chooser/color_chooser_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ui/views/controls/button/blue_button.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/button/blue_button_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/button/button.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/button/checkbox.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/button/checkbox.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/button/custom_button.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/button/custom_button_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/button/image_button.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/button/label_button.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/button/label_button_border.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/label_button_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/button/menu_button.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/button/menu_button_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/button/radio_button.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/combobox/combobox.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/combobox/combobox.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/combobox/combobox_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/focusable_border.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/glow_hover_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/image_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/label.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/label.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/label_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/link.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/display_change_listener_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_controller_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_event_dispatcher.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_host_root_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_item_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_item_view.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_message_loop_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_message_loop_aura.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_message_loop_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_message_pump_dispatcher_win.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_model_adapter.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_model_adapter_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_runner.h View 3 chunks +6 lines, -4 lines 0 comments Download
M ui/views/controls/menu/menu_runner.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M ui/views/controls/menu/menu_runner_cocoa_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_runner_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_runner_impl.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_runner_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_runner_impl_adapter.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_runner_impl_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_runner_impl_cocoa.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_runner_impl_cocoa.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_runner_impl_interface.h View 3 chunks +4 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_runner_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_scroll_view_container.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_scroll_view_container.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_separator.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_separator_views.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/submenu_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/message_box_view.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/views/controls/message_box_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/native/native_view_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/native/native_view_host_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/native/native_view_host_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/native/native_view_host_mac_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/native/native_view_host_test_base.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/native/native_view_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/prefix_selector.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/controls/prefix_selector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/prefix_selector_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/progress_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/progress_bar.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/resize_area.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scroll_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scroll_view_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar_button.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar_thumb.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scrollbar/kennedy_scroll_bar.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scrollbar/kennedy_scroll_bar.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar_views.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scrollbar/overlay_scroll_bar.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scrollbar/overlay_scroll_bar.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scrollbar/scroll_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/scrollbar_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/separator.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/single_split_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/single_split_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/single_split_view_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/slide_out_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/slider.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/slider_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/styled_label.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/styled_label.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/styled_label_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/table/table_header.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/table/table_header.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/table/table_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/table/table_utils_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/table/table_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/table/table_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/table/table_view_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/table/test_table_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/textfield/textfield_model.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield_model_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield_test_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M ui/views/controls/throbber.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tree/tree_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tree/tree_view_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/webview/unhandled_keyboard_event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/webview/web_dialog_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/webview/webview.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/controls/webview/webview.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M ui/views/controls/webview/webview_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/views/corewm/cursor_height_provider_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/corewm/desktop_capture_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/corewm/tooltip_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/corewm/tooltip_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/corewm/tooltip_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/corewm/tooltip_controller_test_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/corewm/tooltip_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/event_monitor_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/bubble_example.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/bubble_example.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/double_split_view_example.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/example_base.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/examples_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/examples_window.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/examples_with_content_main_exe.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/label_example.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/menu_example.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/multiline_example.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/examples/radio_button_example.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/examples/scroll_view_example.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/single_split_view_example.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/text_example.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/textfield_example.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/examples/throbber_example.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/vector_example.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/examples/widget_example.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/focus/external_focus_tracker.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/focus/focus_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_manager_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_manager_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/focus/focus_manager_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/focus/focus_search.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/focus/focus_traversal_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/focus/view_storage.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/focus/widget_focus_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/layout/box_layout.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/layout/box_layout_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/layout/fill_layout.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/layout/grid_layout.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/layout/grid_layout.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/linux_ui/window_button_order_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/masked_targeter_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/metrics_aura.cc View 1 chunk +1 line, -0 lines 1 comment Download
M ui/views/mouse_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mouse_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mouse_watcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mouse_watcher_view_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/aura_init.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/aura_init.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/mus/display_converter.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/mus/input_method_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/platform_window_mus.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/mus/platform_window_mus.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/surface_binding.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/surface_binding.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/mus/surface_context_factory.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/views/mus/surface_context_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/window_manager_connection.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/painter.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/painter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/repeat_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/round_rect_painter.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/shadow_border.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/style/mac/dialog_button_border_mac_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/style/platform_style.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/capture_tracking_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/combobox_test_api.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ui/views/test/desktop_test_views_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/desktop_test_views_delegate_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/event_generator_delegate_mac.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/test/focus_manager_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/menu_runner_test_api.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/slider_test_api.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/test_views.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/test_views_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/test/test_views_delegate_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/test_widget_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/ui_controls_factory_desktop_aurax11.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/views_test_base.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/test/views_test_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/views_test_helper_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/webview_test_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/widget_test.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/test/widget_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/widget_test_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/widget_test_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/x11_property_change_waiter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/touchui/touch_selection_menu_runner_views.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/touchui/touch_selection_menu_runner_views_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/view.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/views/view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/view_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view_model.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/view_model_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view_targeter_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/view_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/views_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/views_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/views_switches.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/android/native_widget_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_capture_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_cursor_loader_updater_auralinux.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_dispatcher_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_dispatcher_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drop_target_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_event_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_focus_rules.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_cursor_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_position_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11_interactive_uitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_topmost_window_finder.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_topmost_window_finder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/drop_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/drop_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_mac_interactive_uitest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_mac_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/root_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/root_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/root_view_targeter.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/root_view_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/tooltip_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/tooltip_manager_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/widget_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/widget_deletion_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_hwnd_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/window_reorderer.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/window_reorderer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/win/fullscreen_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/win/hwnd_message_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/win/scoped_fullscreen_visibility.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/win/windows_session_change_observer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/window/custom_frame_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/window/custom_frame_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/window/custom_frame_view_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/window/dialog_client_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/window/dialog_client_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/window/dialog_client_view_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/window/dialog_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/window/dialog_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/window/dialog_delegate_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/window/frame_background.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/window/native_frame_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/window/native_frame_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/window/non_client_view.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543173002/1
5 years ago (2015-12-23 06:04:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-23 06:53:14 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fba04a5abfa4c7740abb03ecb160802e5e66a811 Cr-Commit-Position: refs/heads/master@{#366723}
5 years ago (2015-12-23 06:54:31 UTC) #5
Nico
5 years ago (2015-12-23 21:17:13 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1543173002/diff/1/ui/views/metrics_aura.cc
File ui/views/metrics_aura.cc (right):

https://codereview.chromium.org/1543173002/diff/1/ui/views/metrics_aura.cc#ne...
ui/views/metrics_aura.cc:5: #include "build/build_config.h"
Fun fact: This file used to not include build_config by accident previously, and
hence the `if defined(OS_WIN)` were always false in this file -- even on
Windows!

Powered by Google App Engine
This is Rietveld 408576698