Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1542943002: [proxies] Expose proxies in the API (Closed)

Created:
5 years ago by Camillo Bruni
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@2015-12-17_JSProxy_d8_printing_1530293004
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Expose proxies in the API Add API-accessors for [[ProxyTarget]], [[ProxyHandler]]. Additionally create new proxies and revoke proxies via the API. BUG=v8:1543 LOG=n Committed: https://crrev.com/88b58591aca6b6237442a8c0483cd541f96d41a2 Cr-Commit-Position: refs/heads/master@{#33013}

Patch Set 1 #

Patch Set 2 : reverting d8 changes #

Patch Set 3 : messing around with branches #

Total comments: 2

Patch Set 4 : adressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -37 lines) Patch
M include/v8.h View 1 2 4 chunks +40 lines, -0 lines 0 comments Download
M src/api.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/api.cc View 1 2 5 chunks +53 lines, -6 lines 0 comments Download
M src/builtins.cc View 1 2 2 chunks +1 line, -26 lines 0 comments Download
M src/factory.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1405243006 Patch 40001

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542943002/40001
5 years ago (2015-12-22 14:17:32 UTC) #2
Camillo Bruni
PTAL
5 years ago (2015-12-22 14:22:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-22 14:39:17 UTC) #6
Yang
lgtm with comment. https://codereview.chromium.org/1542943002/diff/40001/test/cctest/test-proxies.cc File test/cctest/test-proxies.cc (right): https://codereview.chromium.org/1542943002/diff/40001/test/cctest/test-proxies.cc#newcode11 test/cctest/test-proxies.cc:11: TEST(Proxy) { I would have put ...
5 years ago (2015-12-22 14:47:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542943002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542943002/60001
5 years ago (2015-12-22 14:52:04 UTC) #10
Camillo Bruni
https://codereview.chromium.org/1542943002/diff/40001/test/cctest/test-proxies.cc File test/cctest/test-proxies.cc (right): https://codereview.chromium.org/1542943002/diff/40001/test/cctest/test-proxies.cc#newcode11 test/cctest/test-proxies.cc:11: TEST(Proxy) { On 2015/12/22 at 14:47:55, Yang wrote: > ...
5 years ago (2015-12-22 14:52:24 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-22 16:36:54 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-22 16:37:36 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/88b58591aca6b6237442a8c0483cd541f96d41a2
Cr-Commit-Position: refs/heads/master@{#33013}

Powered by Google App Engine
This is Rietveld 408576698