[es6] Partially implement Reflect.ownKeys.

[es6] Partially implement Reflect.ownKeys.

Proxies are not properly supported yet.

R=cbruni, rossberg
BUG=

Committed: https://crrev.com/4194d0ebadd2a0a74195c08d5717685b73e68349
Cr-Commit-Position: refs/heads/master@{#31906}

[neis, 2015-11-04 16:33:06]

I know that the additional argument to GetKeys is ugly.  I talked to Camillo and
we agreed that GetKeys should be refactored and simplified anyways, so I want to
keep my change to it in this CL minimal.

[Camillo Bruni, 2015-11-05 08:29:35]

LGTM with the usual nits :)

https://codereview.chromium.org/1405243006/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1405243006/diff/1/src/objects.cc#newcode7668
src/objects.cc:7668: (only_enumerables ? DONT_ENUM : NONE) | PRIVATE_SYMBOL);
If we're already at it, could you move attr_filter to the method start and use
it also for CollectOwnElementKeys further up? (should make things also easier
for migrating all later on)

https://codereview.chromium.org/1405243006/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1405243006/diff/1/src/objects.h#newcode1940
src/objects.h:1940: bool only_enumerables = true);
I know we discussed to move all the flags on the KeyAccu, but could you add an
enum for only_enumerables nevertheless? (I think it makes the call-sites of
GetKeys quite a bit more readable).

https://codereview.chromium.org/1405243006/diff/1/test/mjsunit/harmony/reflec...
File test/mjsunit/harmony/reflect-own-keys.js (right):

https://codereview.chromium.org/1405243006/diff/1/test/mjsunit/harmony/reflec...
test/mjsunit/harmony/reflect-own-keys.js:43: keys.sort();
I don't like that we sort() here... doesn't the spec clearly specify "insertion
order"?
There seem to be other tests that will catch that tough :)

[rossberg, 2015-11-09 17:43:49]

lgtm

[neis, 2015-11-09 22:50:53]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-09 22:51:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1405243006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1405243006/40001

[commit-bot: I haz the power, 2015-11-09 23:26:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-09 23:26:54]

Dry run: This issue passed the CQ dry run.

[neis, 2015-11-09 23:28:25]

The CQ bit was checked by neis@chromium.org

[neis, 2015-11-09 23:28:26]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org,
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1405243006/#ps40001
(title: "Address other comments.")

[commit-bot: I haz the power, 2015-11-09 23:28:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1405243006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1405243006/40001

[commit-bot: I haz the power, 2015-11-09 23:30:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-09 23:31:02]

Patchset 3 (id:??) landed as
https://crrev.com/4194d0ebadd2a0a74195c08d5717685b73e68349
Cr-Commit-Position: refs/heads/master@{#31906}