Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1542753002: postmortem: Remove Context::GLOBAL_OBJECT_INDEX (Closed)

Created:
5 years ago by ofrobots
Modified:
5 years ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com, jgilli
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

postmortem: Remove Context::GLOBAL_OBJECT_INDEX Context::GLOBAL_OBJECT_INDEX has been replaced by NATIVE_CONTEXT_INDEX in https://codereview.chromium.org/1480003002. Update the postmortem data generator to reflect this change. R=bmeurer@chromium.org,yangguo@chromium.org BUG= Committed: https://crrev.com/638e20da7ef7ce6efdeb91075d35ea89c623868e Cr-Commit-Position: refs/heads/master@{#32993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gen-postmortem-metadata.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
ofrobots
5 years ago (2015-12-21 20:19:24 UTC) #1
Yang
On 2015/12/21 20:19:24, ofrobots wrote: lgtm. thanks.
5 years ago (2015-12-21 20:21:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542753002/1
5 years ago (2015-12-21 23:57:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-22 00:18:27 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-22 00:18:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/638e20da7ef7ce6efdeb91075d35ea89c623868e
Cr-Commit-Position: refs/heads/master@{#32993}

Powered by Google App Engine
This is Rietveld 408576698