[runtime] Replace global object link with native context link in all contexts.

[runtime] Replace global object link with native context link in all contexts.

Previously all contexts had a link to the global object, but what is
required in most cases (except for the global load, store and delete
case) is the native context.

This also removes the second dummy global object that was still linked
to every native context. We will add a different mechanism to ensure
that builtins do not pollute the actual global object during
bootstrapping.

Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff.

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel
R=yangguo@chromium.org,mstarzinger@chromium.org

Committed: https://crrev.com/d290f204938295bfecc5c8e645ccfcff6e80ddb8
Cr-Commit-Position: refs/heads/master@{#32375}

Committed: https://crrev.com/47502a238b8185a864bfe6a8d5508b4e67cad40e
Cr-Commit-Position: refs/heads/master@{#32381}

[Benedikt Meurer, 2015-11-27 12:08:18]

Hey Yang,

It's done. Mostly surprisingly straight forward. I'll leave the bootstrapper.cc
cleanup to you. :-)
Please take a look.

Thanks,
Benedikt

[Michael Starzinger, 2015-11-27 12:19:26]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2015-11-27 12:19:27]

LGTM on the "compiler" part, didn't look at the rest.

https://codereview.chromium.org/1480003002/diff/1/src/compiler/js-typed-lower...
File src/compiler/js-typed-lowering.cc (left):

https://codereview.chromium.org/1480003002/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:1299:
AccessBuilder::ForJSGlobalObjectGlobalProxy()),
AccessBuilder::ForJSGlobalObjectGlobalProxy looks unused now. Should we drop it?

https://codereview.chromium.org/1480003002/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:1519:
AccessBuilder::ForJSGlobalObjectNativeContext()),
Likewise for AccessBuilder::ForJSGlobalObjectNativeContext.

[Benedikt Meurer, 2015-11-27 12:20:45]

https://codereview.chromium.org/1480003002/diff/1/src/compiler/js-typed-lower...
File src/compiler/js-typed-lowering.cc (left):

https://codereview.chromium.org/1480003002/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:1299:
AccessBuilder::ForJSGlobalObjectGlobalProxy()),
Nah, the property is still there, so no need to remove the accessors now.

https://codereview.chromium.org/1480003002/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:1519:
AccessBuilder::ForJSGlobalObjectNativeContext()),
Nah, the property is still there, so no need to remove the accessors now.

[Yang, 2015-11-27 12:28:20]

LGTM with comment (haven't checked all ports)

https://codereview.chromium.org/1480003002/diff/1/src/snapshot/snapshot-commo...
File src/snapshot/snapshot-common.cc (right):

https://codereview.chromium.org/1480003002/diff/1/src/snapshot/snapshot-commo...
src/snapshot/snapshot-common.cc:87: // script context that has the global "this"
binding.
Also remove comment.

[Benedikt Meurer, 2015-11-27 12:39:47]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-11-27 12:39:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
yangguo@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1480003002/#ps40001
(title: "Drop comment.")

[commit-bot: I haz the power, 2015-11-27 12:40:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480003002/40001

[commit-bot: I haz the power, 2015-11-27 13:31:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-27 13:32:26]

Description was changed from

==========
[runtime] Replace global object link with native context link in all contexts.

Previously all contexts had a link to the global object, but what is
required in most cases (except for the global load, store and delete
case) is the native context.

This also removes the second dummy global object that was still linked
to every native context. We will add a different mechanism to ensure
that builtins do not pollute the actual global object during
bootstrapping.

Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff.

R=yangguo@chromium.org
==========

to

==========
[runtime] Replace global object link with native context link in all contexts.

Previously all contexts had a link to the global object, but what is
required in most cases (except for the global load, store and delete
case) is the native context.

This also removes the second dummy global object that was still linked
to every native context. We will add a different mechanism to ensure
that builtins do not pollute the actual global object during
bootstrapping.

Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff.

R=yangguo@chromium.org

Committed: https://crrev.com/d290f204938295bfecc5c8e645ccfcff6e80ddb8
Cr-Commit-Position: refs/heads/master@{#32375}
==========

[commit-bot: I haz the power, 2015-11-27 13:32:27]

Patchset 3 (id:??) landed as
https://crrev.com/d290f204938295bfecc5c8e645ccfcff6e80ddb8
Cr-Commit-Position: refs/heads/master@{#32375}

[Michael Achenbach, 2015-11-27 14:29:14]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1478303002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/build....

[Benedikt Meurer, 2015-11-27 16:12:59]

Description was changed from

==========
[runtime] Replace global object link with native context link in all contexts.

Previously all contexts had a link to the global object, but what is
required in most cases (except for the global load, store and delete
case) is the native context.

This also removes the second dummy global object that was still linked
to every native context. We will add a different mechanism to ensure
that builtins do not pollute the actual global object during
bootstrapping.

Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff.

R=yangguo@chromium.org

Committed: https://crrev.com/d290f204938295bfecc5c8e645ccfcff6e80ddb8
Cr-Commit-Position: refs/heads/master@{#32375}
==========

to

==========
[runtime] Replace global object link with native context link in all contexts.

Previously all contexts had a link to the global object, but what is
required in most cases (except for the global load, store and delete
case) is the native context.

This also removes the second dummy global object that was still linked
to every native context. We will add a different mechanism to ensure
that builtins do not pollute the actual global object during
bootstrapping.

Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff.

R=yangguo@chromium.org

Committed: https://crrev.com/d290f204938295bfecc5c8e645ccfcff6e80ddb8
Cr-Commit-Position: refs/heads/master@{#32375}
==========

[Benedikt Meurer, 2015-11-27 16:19:55]

Description was changed from

==========
[runtime] Replace global object link with native context link in all contexts.

Previously all contexts had a link to the global object, but what is
required in most cases (except for the global load, store and delete
case) is the native context.

This also removes the second dummy global object that was still linked
to every native context. We will add a different mechanism to ensure
that builtins do not pollute the actual global object during
bootstrapping.

Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff.

R=yangguo@chromium.org

Committed: https://crrev.com/d290f204938295bfecc5c8e645ccfcff6e80ddb8
Cr-Commit-Position: refs/heads/master@{#32375}
==========

to

==========
[runtime] Replace global object link with native context link in all contexts.

Previously all contexts had a link to the global object, but what is
required in most cases (except for the global load, store and delete
case) is the native context.

This also removes the second dummy global object that was still linked
to every native context. We will add a different mechanism to ensure
that builtins do not pollute the actual global object during
bootstrapping.

Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff.

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel
R=yangguo@chromium.org,mstarzinger@chromium.org

Committed: https://crrev.com/d290f204938295bfecc5c8e645ccfcff6e80ddb8
Cr-Commit-Position: refs/heads/master@{#32375}
==========

[Benedikt Meurer, 2015-11-27 16:27:17]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-11-27 16:27:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
yangguo@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1480003002/#ps60001
(title: "Add patch from Orion for interpreter cementation test. Disable
obsolete/invalid tests.")

[commit-bot: I haz the power, 2015-11-27 16:27:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480003002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480003002/60001

[commit-bot: I haz the power, 2015-11-27 16:59:33]

Description was changed from

==========
[runtime] Replace global object link with native context link in all contexts.

Previously all contexts had a link to the global object, but what is
required in most cases (except for the global load, store and delete
case) is the native context.

This also removes the second dummy global object that was still linked
to every native context. We will add a different mechanism to ensure
that builtins do not pollute the actual global object during
bootstrapping.

Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff.

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel
R=yangguo@chromium.org,mstarzinger@chromium.org

Committed: https://crrev.com/d290f204938295bfecc5c8e645ccfcff6e80ddb8
Cr-Commit-Position: refs/heads/master@{#32375}
==========

to

==========
[runtime] Replace global object link with native context link in all contexts.

Previously all contexts had a link to the global object, but what is
required in most cases (except for the global load, store and delete
case) is the native context.

This also removes the second dummy global object that was still linked
to every native context. We will add a different mechanism to ensure
that builtins do not pollute the actual global object during
bootstrapping.

Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff.

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel
R=yangguo@chromium.org,mstarzinger@chromium.org

Committed: https://crrev.com/d290f204938295bfecc5c8e645ccfcff6e80ddb8
Cr-Commit-Position: refs/heads/master@{#32375}
==========

[commit-bot: I haz the power, 2015-11-27 16:59:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-27 17:00:20]

Description was changed from

==========
[runtime] Replace global object link with native context link in all contexts.

Previously all contexts had a link to the global object, but what is
required in most cases (except for the global load, store and delete
case) is the native context.

This also removes the second dummy global object that was still linked
to every native context. We will add a different mechanism to ensure
that builtins do not pollute the actual global object during
bootstrapping.

Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff.

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel
R=yangguo@chromium.org,mstarzinger@chromium.org

Committed: https://crrev.com/d290f204938295bfecc5c8e645ccfcff6e80ddb8
Cr-Commit-Position: refs/heads/master@{#32375}
==========

to

==========
[runtime] Replace global object link with native context link in all contexts.

Previously all contexts had a link to the global object, but what is
required in most cases (except for the global load, store and delete
case) is the native context.

This also removes the second dummy global object that was still linked
to every native context. We will add a different mechanism to ensure
that builtins do not pollute the actual global object during
bootstrapping.

Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff.

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel
R=yangguo@chromium.org,mstarzinger@chromium.org

Committed: https://crrev.com/d290f204938295bfecc5c8e645ccfcff6e80ddb8
Cr-Commit-Position: refs/heads/master@{#32375}

Committed: https://crrev.com/47502a238b8185a864bfe6a8d5508b4e67cad40e
Cr-Commit-Position: refs/heads/master@{#32381}
==========

[commit-bot: I haz the power, 2015-11-27 17:00:21]

Patchset 4 (id:??) landed as
https://crrev.com/47502a238b8185a864bfe6a8d5508b4e67cad40e
Cr-Commit-Position: refs/heads/master@{#32381}