Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1542673002: Reland of "MIPS64: Fix trunc_l_[s,d] in simulator." (Closed)

Created:
5 years ago by akos.palfi.imgtec
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "MIPS64: Fix trunc_l_[s,d] in simulator." The trunc_l_[s,d] instructions incorrectly returns success when the input is INT64_MAX. TEST=test-run-machops/RunTryTruncateFloat32ToInt64WithCheck,test-run-machops/RunTryTruncateFloat64ToInt64WithCheck BUG= Committed: https://crrev.com/e93b83069dc8103ba2e4111a206307c5e7187776 Cr-Commit-Position: refs/heads/master@{#32990}

Patch Set 1 : Base #

Patch Set 2 : Fix R6 test failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M src/mips/simulator-mips.cc View 1 6 chunks +12 lines, -4 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 1 6 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
akos.palfi.imgtec
PTAL.
5 years ago (2015-12-21 18:58:05 UTC) #2
balazs.kilvady
LGTM
5 years ago (2015-12-21 19:05:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542673002/20001
5 years ago (2015-12-21 19:23:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-21 19:41:25 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-21 19:41:42 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e93b83069dc8103ba2e4111a206307c5e7187776
Cr-Commit-Position: refs/heads/master@{#32990}

Powered by Google App Engine
This is Rietveld 408576698