Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 154263007: Let V8 know about the external memory owned by large StaticNodeList (Closed)

Created:
6 years, 10 months ago by Jens Widell
Modified:
6 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Let V8 know about the external memory owned by large StaticNodeList If a script allocates many large but short-lived StaticNodeList objects, for instance by using querySelectorAll() in an inefficient way, memory usage will balloon since V8's garbage collector won't realize that much memory owned by it is being allocated, and thus doesn't run its GC. Reporting external allocated memory to V8 is unnecessary overhead for small objects, so only do it for objects larger than a limit. BUG=342752 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M Source/core/dom/StaticNodeList.h View 1 chunk +12 lines, -6 lines 0 comments Download
M Source/core/dom/StaticNodeList.cpp View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jens Widell
This is pretty much the same as https://codereview.chromium.org/64203002 except for the limit that keeps us ...
6 years, 10 months ago (2014-02-11 15:52:24 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-11 15:54:23 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 10 months ago (2014-02-11 15:57:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/154263007/1
6 years, 10 months ago (2014-02-11 15:57:27 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 18:35:50 UTC) #5
Message was sent while issue was closed.
Change committed as 166937

Powered by Google App Engine
This is Rietveld 408576698