Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 64203002: Report size of the external memory to V8 in StaticNodeList (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
7 years, 1 month ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Report size of the external memory to V8 in StaticNodeList When we create a lot of moderately large NodeLists, the V8 GC heuristic isn't aggressively enough collecting wrappers which can lead to an OOM crash. Reporting the size of the nodelists to V8 fixes this issue. The other kinds of nodelists don't have variable sized members, so they don't have this problem BUG=315082 TEST=opening PerformanceTests/Parser/query-selector-all-class.html in a release build content shell on a fast computer doesn't crash. R=dslomov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161546

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M Source/core/dom/StaticNodeList.h View 1 chunk +3 lines, -6 lines 0 comments Download
M Source/core/dom/StaticNodeList.cpp View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
plz review
7 years, 1 month ago (2013-11-07 13:15:55 UTC) #1
Dmitry Lomov (no reviews)
On 2013/11/07 13:15:55, jochen wrote: > plz review Hmm, you adjust V8 external memory even ...
7 years, 1 month ago (2013-11-07 14:29:46 UTC) #2
jochen (gone - plz use gerrit)
On 2013/11/07 14:29:46, Dmitry Lomov (chromium) wrote: > On 2013/11/07 13:15:55, jochen wrote: > > ...
7 years, 1 month ago (2013-11-07 14:35:53 UTC) #3
Dmitry Lomov (no reviews)
On 2013/11/07 14:35:53, jochen wrote: > On 2013/11/07 14:29:46, Dmitry Lomov (chromium) wrote: > > ...
7 years, 1 month ago (2013-11-07 15:13:39 UTC) #4
haraken
LGTM. The AdjustAmountOfMemory calls in this CL are balanced, so it looks definitely safe.
7 years, 1 month ago (2013-11-07 15:25:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/64203002/90001
7 years, 1 month ago (2013-11-07 15:25:56 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 17:43:11 UTC) #7
Message was sent while issue was closed.
Change committed as 161546

Powered by Google App Engine
This is Rietveld 408576698