Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1542353002: Make the standalone msvs_disabled_warnings block match Chromium's. (Closed)

Created:
4 years, 12 months ago by Lei Zhang
Modified:
4 years, 12 months ago
Reviewers:
Nico
CC:
pdfium-reviews_googlegroups.com, jochen (gone - plz use gerrit)
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make the standalone msvs_disabled_warnings block match Chromium's. TBR=thakis@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/9fb1413926b55727d8f00dd54fbe144a883d4873

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -6 lines) Patch
M build/standalone.gypi View 1 chunk +93 lines, -6 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
I think this will stop a lot of the random PDFium win bot's redness.
4 years, 12 months ago (2015-12-24 05:43:53 UTC) #2
Lei Zhang
Committed patchset #1 (id:1) manually as 9fb1413926b55727d8f00dd54fbe144a883d4873 (tree was closed).
4 years, 12 months ago (2015-12-24 05:45:37 UTC) #4
Nico
lgtm https://codereview.chromium.org/1542353002/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1542353002/diff/1/build/standalone.gypi#newcode264 build/standalone.gypi:264: 4481, # Nonstandard extension used: override specifier 'keyword' ...
4 years, 12 months ago (2015-12-24 12:00:43 UTC) #5
Lei Zhang
4 years, 12 months ago (2015-12-24 18:33:38 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1542353002/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/1542353002/diff/1/build/standalone.gypi#newco...
build/standalone.gypi:264: 4481, # Nonstandard extension used: override
specifier 'keyword'
On 2015/12/24 12:00:43, Nico wrote:
> this one hopefully doesn't fire anymore in vs2013?

I don't think so, but I'm just syncing this with Chromium's copy. Do you want to
try removing it there?

Powered by Google App Engine
This is Rietveld 408576698