Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: build/standalone.gypi

Issue 1542353002: Make the standalone msvs_disabled_warnings block match Chromium's. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 PDFium Authors. All rights reserved. 1 # Copyright 2014 PDFium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Definitions to be used when building stand-alone PDFium binaries. 5 # Definitions to be used when building stand-alone PDFium binaries.
6 6
7 { 7 {
8 'variables': { 8 'variables': {
9 'component%': 'static_library', 9 'component%': 'static_library',
10 'clang%': 0, 10 'clang%': 0,
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 'defines': [ 183 'defines': [
184 # Don't use deprecated V8 APIs anywhere. 184 # Don't use deprecated V8 APIs anywhere.
185 'V8_DEPRECATION_WARNINGS', 185 'V8_DEPRECATION_WARNINGS',
186 ], 186 ],
187 'msvs_cygwin_dirs': ['<(DEPTH)/v8/third_party/cygwin'], 187 'msvs_cygwin_dirs': ['<(DEPTH)/v8/third_party/cygwin'],
188 'msvs_configuration_attributes': { 188 'msvs_configuration_attributes': {
189 'OutputDirectory': '<(DEPTH)\\build\\$(ConfigurationName)', 189 'OutputDirectory': '<(DEPTH)\\build\\$(ConfigurationName)',
190 'IntermediateDirectory': '$(OutDir)\\obj\\$(ProjectName)', 190 'IntermediateDirectory': '$(OutDir)\\obj\\$(ProjectName)',
191 'CharacterSet': '1', 191 'CharacterSet': '1',
192 }, 192 },
193 'msvs_disabled_warnings': [4800, 4996, 4456, 4457, 4458, 4459, 4091], 193 'msvs_disabled_warnings': [
194 # 4456, 4457, 4458, 4459 are variable shadowing warnings that are new in 194 # ####
195 # VS2015. 195 # This section is PDFium specific.
196 # C4091: 'typedef ': ignored on left of 'X' when no variable is 196 # ####
197 # declared. 197
198 # This happens in a number of Windows headers with VS 2015. 198 # C4800: forcing value to bool 'true' or 'false' (performance warning)
199 4800,
200
201 # ####
202 # This section should match Chromium's build/common.gypi.
203 # ####
204
205 # C4091: 'typedef ': ignored on left of 'X' when no variable is
206 # declared.
207 # This happens in a number of Windows headers. Dumb.
208 4091,
209
210 # C4127: conditional expression is constant
211 # This warning can in theory catch dead code and other problems, but
212 # triggers in far too many desirable cases where the conditional
213 # expression is either set by macros or corresponds some legitimate
214 # compile-time constant expression (due to constant template args,
215 # conditionals comparing the sizes of different types, etc.). Some of
216 # these can be worked around, but it's not worth it.
217 4127,
218
219 # C4351: new behavior: elements of array 'array' will be default
220 # initialized
221 # This is a silly "warning" that basically just alerts you that the
222 # compiler is going to actually follow the language spec like it's
223 # supposed to, instead of not following it like old buggy versions
224 # did. There's absolutely no reason to turn this on.
225 4351,
226
227 # C4355: 'this': used in base member initializer list
228 # It's commonly useful to pass |this| to objects in a class'
229 # initializer list. While this warning can catch real bugs, most of
230 # the time the constructors in question don't attempt to call methods
231 # on the passed-in pointer (until later), and annotating every legit
232 # usage of this is simply more hassle than the warning is worth.
233 4355,
234
235 # C4503: 'identifier': decorated name length exceeded, name was
236 # truncated
237 # This only means that some long error messages might have truncated
238 # identifiers in the presence of lots of templates. It has no effect
239 # on program correctness and there's no real reason to waste time
240 # trying to prevent it.
241 4503,
242
243 # Warning C4589 says: "Constructor of abstract class ignores
244 # initializer for virtual base class." Disable this warning because it
245 # is flaky in VS 2015 RTM. It triggers on compiler generated
246 # copy-constructors in some cases.
247 4589,
248
249 # C4611: interaction between 'function' and C++ object destruction is
250 # non-portable
251 # This warning is unavoidable when using e.g. setjmp/longjmp. MSDN
252 # suggests using exceptions instead of setjmp/longjmp for C++, but
253 # Chromium code compiles without exception support. We therefore have
254 # to use setjmp/longjmp for e.g. JPEG decode error handling, which
255 # means we have to turn off this warning (and be careful about how
256 # object destruction happens in such cases).
257 4611,
258
259 # TODO(thestig): These warnings are level 4. They will be slowly
260 # removed as code is fixed.
261 4100, # Unreferenced formal parameter
262 4121, # Alignment of a member was sensitive to packing
263 4244, # Conversion from 'type1' to 'type2', possible loss of data
264 4481, # Nonstandard extension used: override specifier 'keyword'
Nico 2015/12/24 12:00:43 this one hopefully doesn't fire anymore in vs2013?
Lei Zhang 2015/12/24 18:33:38 I don't think so, but I'm just syncing this with C
265 4505, # Unreferenced local function has been removed
266 4510, # Default constructor could not be generated
267 4512, # Assignment operator could not be generated
268 4610, # Object can never be instantiated
269 4838, # Narrowing conversion. Doesn't seem to be very useful.
270 4995, # 'X': name was marked as #pragma deprecated
271 4996, # 'X': was declared deprecated (for GetVersionEx).
272
273 # These are variable shadowing warnings that are new in VS2015. We
274 # should work through these at some point -- they may be removed from
275 # the RTM release in the /W4 set.
276 4456, 4457, 4458, 4459,
277
278 # TODO(brucedawson): http://crbug.com/554200 4312 is a VS
279 # 2015 64-bit warning for integer to larger pointer
280 4312,
281
282 # ####
283 # Do not add PDFium specific entries here. Add them to the top.
284 # ####
285 ],
199 'msvs_settings': { 286 'msvs_settings': {
200 'VCCLCompilerTool': { 287 'VCCLCompilerTool': {
201 'MinimalRebuild': 'false', 288 'MinimalRebuild': 'false',
202 'BufferSecurityCheck': 'true', 289 'BufferSecurityCheck': 'true',
203 'EnableFunctionLevelLinking': 'true', 290 'EnableFunctionLevelLinking': 'true',
204 'RuntimeTypeInfo': 'false', 291 'RuntimeTypeInfo': 'false',
205 'WarningLevel': '3', 292 'WarningLevel': '3',
206 'DebugInformationFormat': '3', 293 'DebugInformationFormat': '3',
207 'Detect64BitPortabilityProblems': 'false', 294 'Detect64BitPortabilityProblems': 'false',
208 'conditions': [ 295 'conditions': [
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 ], 440 ],
354 }], # OS=="linux" or OS=="mac" 441 }], # OS=="linux" or OS=="mac"
355 ["use_goma==1", { 442 ["use_goma==1", {
356 'make_global_settings': [ 443 'make_global_settings': [
357 ['CC_wrapper', '<(gomadir)/gomacc'], 444 ['CC_wrapper', '<(gomadir)/gomacc'],
358 ['CXX_wrapper', '<(gomadir)/gomacc'], 445 ['CXX_wrapper', '<(gomadir)/gomacc'],
359 ], 446 ],
360 }], # use_goma==1 447 }], # use_goma==1
361 ], 448 ],
362 } 449 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698