Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 154223003: Exclude vulcanize-generated HTML/JS from PRESUBMIT.py checks (Closed)

Created:
6 years, 10 months ago by raymes
Modified:
6 years, 10 months ago
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Exclude vulcanize-generated HTML/JS from PRESUBMIT.py checks These files are automatically generated for the PDF extension. The long term solution is not to check in vulcanize-generated files. These files may not be needed once HTMLImports are fully implemented in chrome. BUG=303491 R=arv@chromium.org, maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251890

Patch Set 1 #

Total comments: 2

Patch Set 2 : \ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M PRESUBMIT.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/PRESUBMIT.py View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
raymes
6 years, 10 months ago (2014-02-06 03:30:48 UTC) #1
M-A Ruel
lgtm https://codereview.chromium.org/154223003/diff/1/chrome/browser/resources/PRESUBMIT.py File chrome/browser/resources/PRESUBMIT.py (right): https://codereview.chromium.org/154223003/diff/1/chrome/browser/resources/PRESUBMIT.py#newcode53 chrome/browser/resources/PRESUBMIT.py:53: return (not(maybe_resource.LocalPath() in WHITELIST) and then it is ...
6 years, 10 months ago (2014-02-15 01:46:57 UTC) #2
raymes
https://codereview.chromium.org/154223003/diff/1/chrome/browser/resources/PRESUBMIT.py File chrome/browser/resources/PRESUBMIT.py (right): https://codereview.chromium.org/154223003/diff/1/chrome/browser/resources/PRESUBMIT.py#newcode53 chrome/browser/resources/PRESUBMIT.py:53: return (not(maybe_resource.LocalPath() in WHITELIST) and On 2014/02/15 01:46:57, M-A ...
6 years, 10 months ago (2014-02-16 23:14:30 UTC) #3
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 10 months ago (2014-02-16 23:14:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/154223003/60001
6 years, 10 months ago (2014-02-16 23:15:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-16 23:19:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-16 23:19:12 UTC) #7
raymes
+arv for chrome/browser/resources/PRESUBMIT.py
6 years, 10 months ago (2014-02-17 23:16:36 UTC) #8
arv (Not doing code reviews)
LGTM
6 years, 10 months ago (2014-02-18 17:58:10 UTC) #9
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 10 months ago (2014-02-18 22:55:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/154223003/60001
6 years, 10 months ago (2014-02-18 22:57:34 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 22:59:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-18 22:59:13 UTC) #13
raymes
6 years, 10 months ago (2014-02-19 00:09:29 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 manually as r251890 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698