chrome/browser/resources/PRESUBMIT.py - Issue 154223003: Exclude vulcanize-generated HTML/JS from PRESUBMIT.py checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/PRESUBMIT.py

Issue 154223003: Exclude vulcanize-generated HTML/JS from PRESUBMIT.py checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: \ Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/PRESUBMIT.py

diff --git a/chrome/browser/resources/PRESUBMIT.py b/chrome/browser/resources/PRESUBMIT.py

index 0aa0d6350df9b7b7482078d93211f0dd69a8a0ed..831864c33b4236beca0807becff5abbbd535997f 100644

--- a/chrome/browser/resources/PRESUBMIT.py

+++ b/chrome/browser/resources/PRESUBMIT.py

@@ -47,8 +47,11 @@ def _CommonChecks(input_api, output_api):

def _html_css_js_resource(p):

return p.endswith(('.html', '.css', '.js')) and p.startswith(resources)

+ BLACKLIST = ['chrome/browser/resources/pdf/index.html',

+ 'chrome/browser/resources/pdf/index.js']

def is_resource(maybe_resource):

- return _html_css_js_resource(maybe_resource.AbsoluteLocalPath())

+ return (maybe_resource.LocalPath() not in BLACKLIST and

+ _html_css_js_resource(maybe_resource.AbsoluteLocalPath()))

results.extend(css_checker.CSSChecker(

input_api, output_api, file_filter=is_resource).RunChecks())

« no previous file with comments | « PRESUBMIT.py ('k') | no next file » | no next file with comments »