Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1542213002: Merge to XFA: Start using allowed C++11 features. (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
Reviewers:
Nico, David Lattimore
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Start using allowed C++11 features. TBR=dml@google.com, thakis@chromium.org Review URL: https://codereview.chromium.org/1544923002 . Review URL: https://codereview.chromium.org/1545823002 . (cherry picked from commit ba2586d2c0a50df14aa2549a0a841e1d4b9af4b6) (cherry picked from commit 87f7d29531dabfd66e547a6be31a08272ff631d5) Committed: https://pdfium.googlesource.com/pdfium/+/9ba6a147311eacb933c175168de6d11c439985d3

Patch Set 1 #

Patch Set 2 : fix mac/win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -53 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 5 chunks +9 lines, -10 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SddProc.cpp View 6 chunks +5 lines, -9 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M samples/image_diff.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/base/nonstd_unique_ptr.h View 3 chunks +3 lines, -9 lines 0 comments Download
M third_party/base/nonstd_unique_ptr_unittest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/base/stl_util.h View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
TBR
5 years ago (2015-12-22 22:57:41 UTC) #2
Lei Zhang
Committed patchset #2 (id:20001) manually as 9ba6a147311eacb933c175168de6d11c439985d3.
5 years ago (2015-12-22 22:57:52 UTC) #4
David Lattimore
lgtm
5 years ago (2015-12-22 22:58:32 UTC) #5
Nico
out of curiosity, what's the game plan for the xfa branch? will it be around ...
5 years ago (2015-12-22 22:59:56 UTC) #6
Lei Zhang
5 years ago (2015-12-22 23:18:19 UTC) #7
Message was sent while issue was closed. 
On 2015/12/22 22:59:56, Nico wrote:
> out of curiosity, what's the game plan for the xfa branch? will it be around
for
> many years to come?

Hopefully not much longer. XFA will likely replace master in a few months?

Powered by Google App Engine
This is Rietveld 408576698