Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1544923002: Start using allowed C++11 features. (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
Reviewers:
Nico, David Lattimore
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -53 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 5 chunks +9 lines, -10 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SddProc.cpp View 6 chunks +5 lines, -9 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samples/image_diff.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/base/nonstd_unique_ptr.h View 3 chunks +3 lines, -9 lines 0 comments Download
M third_party/base/nonstd_unique_ptr_unittest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/base/stl_util.h View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
5 years ago (2015-12-22 21:56:14 UTC) #3
Nico
nice, lgtm I think you can also use std::unique_ptr. The only reason we don't use ...
5 years ago (2015-12-22 21:58:30 UTC) #4
Lei Zhang
On 2015/12/22 21:58:30, Nico wrote: > nice, lgtm > > I think you can also ...
5 years ago (2015-12-22 22:06:17 UTC) #5
David Lattimore
lgtm I don't recall exactly what the compilation problem we had before was, but I ...
5 years ago (2015-12-22 22:33:09 UTC) #6
Lei Zhang
5 years ago (2015-12-22 22:44:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
ba2586d2c0a50df14aa2549a0a841e1d4b9af4b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698