Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1542193002: Merge to XFA: Add ContainsKey() and ContainsValue() and use them where appropriate. (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Add ContainsKey() and ContainsValue() and use them where appropriate. TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1540263003 . (cherry picked from commit 1fc92867ca53f0fba4272fbee3814d844f487495) Committed: https://pdfium.googlesource.com/pdfium/+/cd2bb30aba89a05c0bbd4d6973fa070205e3a1e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -44 lines) Patch
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 6 chunks +8 lines, -12 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 4 chunks +5 lines, -8 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/base/stl_util.h View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
TBR
5 years ago (2015-12-22 21:49:38 UTC) #1
Lei Zhang
Committed patchset #1 (id:1) manually as cd2bb30aba89a05c0bbd4d6973fa070205e3a1e8 (presubmit successful).
5 years ago (2015-12-22 21:49:49 UTC) #3
Oliver Chang
5 years ago (2015-12-22 21:55:10 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698