Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1540263003: Add ContainsKey() and ContainsValue() and use them where appropriate. (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add ContainsKey() and ContainsValue() and use them where appropriate. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/1fc92867ca53f0fba4272fbee3814d844f487495

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -44 lines) Patch
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 6 chunks +8 lines, -12 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 4 chunks +5 lines, -8 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/base/stl_util.h View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
Hopefully these make the code a little easier to read.
5 years ago (2015-12-21 23:58:52 UTC) #2
Oliver Chang
lgtm
5 years ago (2015-12-22 00:21:14 UTC) #3
Lei Zhang
5 years ago (2015-12-22 21:48:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1fc92867ca53f0fba4272fbee3814d844f487495 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698