Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: sync/engine/net/server_connection_manager.h

Issue 15421011: Use OAuth2 token for sync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/engine/net/server_connection_manager.h
diff --git a/sync/engine/net/server_connection_manager.h b/sync/engine/net/server_connection_manager.h
index 917d5b427c699a4ad29bf52095cc90eda68a9767..987d127cfe8a31daa44324073a2116127ec9ce83 100644
--- a/sync/engine/net/server_connection_manager.h
+++ b/sync/engine/net/server_connection_manager.h
@@ -67,6 +67,11 @@ struct SYNC_EXPORT_PRIVATE HttpResponse {
// TODO(idana): the server no longer returns RETRY so we should remove this
// value.
RETRY,
+
+ // TOKEN_REFRESHED is not really a response from server, but a state of
+ // connection after AUTH_ERROR when new access token was issued but not yet
tim (not reviewing) 2013/05/23 19:03:42 Issued by who? Not sure I know what this is about
pavely 2013/05/30 07:42:12 Removed this.
+ // used in requests to server.
+ TOKEN_REFRESHED,
};
// The HTTP Status code.
@@ -256,9 +261,11 @@ class SYNC_EXPORT_PRIVATE ServerConnectionManager {
return proto_sync_path_;
}
+public:
tim (not reviewing) 2013/05/23 19:03:42 Move the call up to the public section instead.
pavely 2013/05/30 07:42:12 I reverted this change.
// Updates server_status_ and notifies listeners if server_status_ changed
void SetServerStatus(HttpResponse::ServerConnectionCode server_status);
+protected:
tim (not reviewing) 2013/05/23 19:03:42 indent is off.
// NOTE: Tests rely on this protected function being virtual.
//
// Internal PostBuffer base function.

Powered by Google App Engine
This is Rietveld 408576698