Use OAuth2 token for sync

sync/engine/net/server_connection_manager.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_ENGINE_NET_SERVER_CONNECTION_MANAGER_H_
 #define SYNC_ENGINE_NET_SERVER_CONNECTION_MANAGER_H_
 
 #include <iosfwd>
 #include <string>
 
@@ skipping 49 matching lines @@
 
     // SERVER_CONNECTION_OK is returned when request was handled correctly.
     SERVER_CONNECTION_OK,
 
     // RETRY is returned when a Commit request fails with a RETRY response from
     // the server.
     //
     // TODO(idana): the server no longer returns RETRY so we should remove this
     // value.
     RETRY,
+
+    // TOKEN_REFRESHED is not really a response from server, but a state of
+    // connection after AUTH_ERROR when new access token was issued but not yet

[tim (not reviewing), 2013/05/23 19:03:42]

Issued by who?  Not sure I know what this is about?

[pavely, 2013/05/30 07:42:12]

Removed this.

+    // used in requests to server.
+    TOKEN_REFRESHED,
   };
 
   // The HTTP Status code.
   int64 response_code;
 
   // The value of the Content-length header.
   int64 content_length;
 
   // The size of a download request's payload.
   int64 payload_length;
@@ skipping 169 matching lines @@
   const std::string auth_token() const {
     DCHECK(thread_checker_.CalledOnValidThread());
     return auth_token_;
   }
 
  protected:
   inline std::string proto_sync_path() const {
     return proto_sync_path_;
   }
 
+public:

[tim (not reviewing), 2013/05/23 19:03:42]

Move the call up to the public section instead.

[pavely, 2013/05/30 07:42:12]

I reverted this change.

   // Updates server_status_ and notifies listeners if server_status_ changed
   void SetServerStatus(HttpResponse::ServerConnectionCode server_status);
 
+protected:

[tim (not reviewing), 2013/05/23 19:03:42]

indent is off.

   // NOTE: Tests rely on this protected function being virtual.
   //
   // Internal PostBuffer base function.
   virtual bool PostBufferToPath(PostBufferParams*,
                                 const std::string& path,
                                 const std::string& auth_token,
                                 ScopedServerStatusWatcher* watcher);
 
   // An internal helper to clear our auth_token_ and cache the old version
   // in |previously_invalidated_token_| to shelter us from retrying with a
@@ skipping 71 matching lines @@
   void NotifyStatusChanged();
 
   DISALLOW_COPY_AND_ASSIGN(ServerConnectionManager);
 };
 
 std::ostream& operator<<(std::ostream& s, const struct HttpResponse& hr);
 
 }  // namespace syncer
 
 #endif  // SYNC_ENGINE_NET_SERVER_CONNECTION_MANAGER_H_