Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 154183002: Update HTMLCollection.namedItem() to use the id/name cache (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, esprehn
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update HTMLCollection.namedItem() to use the id/name cache. HTMLCollection maintains an id/name cache internally. It was used by namedItems() method but strangely not by the namedItem() one. This change is good for performance as HTMLCollection.namedItem() will now use the cache when available and thus avoid traversing the DOM tree unnecessarily. There should be not web-exposed behavior change. This functionality is covered by a decent amount of layout tests. The CL also gets rid of HTMLCollection::checkForNameMatch() method as it is no longer used. HTMLCollection::updateNameCache() already has the same checks inlined. R=arv, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -33 lines) Patch
M Source/core/html/HTMLCollection.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLCollection.cpp View 2 chunks +7 lines, -32 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Inactive
6 years, 10 months ago (2014-02-04 20:50:18 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 10 months ago (2014-02-04 21:00:29 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-05 00:04:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/154183002/1
6 years, 10 months ago (2014-02-05 00:04:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/154183002/1
6 years, 10 months ago (2014-02-05 00:41:14 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 01:11:23 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 10 months ago (2014-02-05 01:11:24 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-05 01:18:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/154183002/1
6 years, 10 months ago (2014-02-05 01:18:37 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 03:45:20 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 10 months ago (2014-02-05 03:45:21 UTC) #11
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-05 13:23:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/154183002/1
6 years, 10 months ago (2014-02-05 13:23:50 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 14:18:42 UTC) #14
Message was sent while issue was closed.
Change committed as 166498

Powered by Google App Engine
This is Rietveld 408576698