Source/core/html/HTMLCollection.h - Issue 154183002: Update HTMLCollection.namedItem() to use the id/name cache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLCollection.h

Issue 154183002: Update HTMLCollection.namedItem() to use the id/name cache (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLCollection.h

diff --git a/Source/core/html/HTMLCollection.h b/Source/core/html/HTMLCollection.h

index dc62bd0b4f1cad66e8584a68f115c8fcfc851a40..56ed514faf7f2e96020a07860e3301b98cea0661 100644

--- a/Source/core/html/HTMLCollection.h

+++ b/Source/core/html/HTMLCollection.h

@@ -75,7 +75,6 @@ protected:

void appendNameCache(const AtomicString& name, Element* element) const { append(m_nameCache, name, element); }

private:

- bool checkForNameMatch(const Element&, bool checkName, const AtomicString& name) const;

Element* traverseNextElement(Element& previous, const ContainerNode& root) const;

static void append(NodeCacheMap&, const AtomicString&, Element*);

« no previous file with comments | « no previous file | Source/core/html/HTMLCollection.cpp » ('j') | no next file with comments »