remove SkCanvas::createCompatibleDevice, and add SkCanvas::newSurface

remove SkCanvas::createCompatibleDevice, and add SkCanvas::newSurface

BUG=skia:
R=bsalomon@google.com

Committed: https://code.google.com/p/skia/source/detail?r=13319

[reed1, 2014-02-05 15:07:42]

gm:extractbitmap has been changed. It was calling
canvas->createCompatibleDevice, and constructing a canvas from that. In the case
where the original canvas was for a picture, its "compatible" device was in fact
a raster device, so we created a rastercanvas from it.

The new pattern is to ask the canvas for a compatible surface/canvas, rather
than device. In this world, a picturecanvas creates a picturesurface. For that
new surface, there is no (real) bitmap behind it, hence we can't cal
extractSubset on the bitmap and expect to get anything that draws.

[bsalomon, 2014-02-05 15:16:02]

lgtm w/ two inline comments

https://codereview.chromium.org/154163002/diff/40001/expectations/gm/ignored-...
File expectations/gm/ignored-tests.txt (right):

https://codereview.chromium.org/154163002/diff/40001/expectations/gm/ignored-...
expectations/gm/ignored-tests.txt:38: extractbitmap
Quit crowding in on my comment!

https://codereview.chromium.org/154163002/diff/40001/src/utils/SkDeferredCanv...
File src/utils/SkDeferredCanvas.cpp (right):

https://codereview.chromium.org/154163002/diff/40001/src/utils/SkDeferredCanv...
src/utils/SkDeferredCanvas.cpp:501: return immediateDevice()->newSurface(info);
this-> ?

[reed1, 2014-02-05 15:21:14]

https://codereview.chromium.org/154163002/diff/40001/expectations/gm/ignored-...
File expectations/gm/ignored-tests.txt (right):

https://codereview.chromium.org/154163002/diff/40001/expectations/gm/ignored-...
expectations/gm/ignored-tests.txt:38: extractbitmap
On 2014/02/05 15:16:02, bsalomon wrote:
> Quit crowding in on my comment!

Done.

https://codereview.chromium.org/154163002/diff/40001/src/utils/SkDeferredCanv...
File src/utils/SkDeferredCanvas.cpp (right):

https://codereview.chromium.org/154163002/diff/40001/src/utils/SkDeferredCanv...
src/utils/SkDeferredCanvas.cpp:501: return immediateDevice()->newSurface(info);
On 2014/02/05 15:16:02, bsalomon wrote:
> this-> ?

Done.

[reed1, 2014-02-05 15:32:29]

Committed patchset #4 manually as r13319 (presubmit successful).

[scroggo, 2014-02-05 16:41:12]

https://codereview.chromium.org/154163002/diff/130001/gm/extractbitmap.cpp
File gm/extractbitmap.cpp (right):

https://codereview.chromium.org/154163002/diff/130001/gm/extractbitmap.cpp#ne...
gm/extractbitmap.cpp:13: #include "SkSurface.h"
Did you mean to call newSurface in this file? It currently does not appear to
need this include.

https://codereview.chromium.org/154163002/diff/130001/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/154163002/diff/130001/include/core/SkCanvas.h...
include/core/SkCanvas.h:128: *  be maximally compatible when used with this
canvas.
What does it mean to be used with this canvas? Drawn to this canvas?