Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1541163002: GN(android) Don't enable --gc-sections in debug mode. (Closed)

Created:
5 years ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
Yaron, jam, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(android) Don't enable --gc-sections by default in debug mode. The flag can cover over legitimate link errors. GYP does not enable it for debug builds. BUG=159847 Committed: https://crrev.com/c869f0e3f9117634a7980514732d6d743a522213 Cr-Commit-Position: refs/heads/master@{#367756}

Patch Set 1 #

Patch Set 2 : Fix failures #

Patch Set 3 : Fix things #

Patch Set 4 : fix gn gen #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -37 lines) Patch
M build/config/compiler/BUILD.gn View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M chrome/BUILD.gn View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 2 chunks +7 lines, -0 lines 0 comments Download
M mojo/runner/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/message_center/BUILD.gn View 1 2 3 2 chunks +39 lines, -35 lines 0 comments Download

Depends on Patchset:

Issue 1543003005 Patch 1

Messages

Total messages: 26 (14 generated)
agrieve
On 2015/12/22 16:40:16, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org 🎅
5 years ago (2015-12-22 16:40:33 UTC) #3
Yaron
lgtm
5 years ago (2015-12-22 17:09:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541163002/1
5 years ago (2015-12-22 17:45:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/2029)
5 years ago (2015-12-22 18:19:22 UTC) #8
agrieve
☃
5 years ago (2015-12-23 20:03:41 UTC) #10
sky
sky->jam
4 years, 12 months ago (2015-12-27 23:28:38 UTC) #13
jam
rubberstamp lgtm
4 years, 12 months ago (2015-12-28 19:51:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541163002/40001
4 years, 11 months ago (2016-01-05 19:47:59 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/48550)
4 years, 11 months ago (2016-01-05 19:53:07 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541163002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541163002/60001
4 years, 11 months ago (2016-01-06 02:16:16 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-06 02:48:17 UTC) #24
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 02:49:19 UTC) #26
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/c869f0e3f9117634a7980514732d6d743a522213
Cr-Commit-Position: refs/heads/master@{#367756}

Powered by Google App Engine
This is Rietveld 408576698