Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: chrome/BUILD.gn

Issue 1541163002: GN(android) Don't enable --gc-sections in debug mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix gn gen Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index d741423927b7be6f43066f886ab28e632f22942b..b7481faad874330641d2ddae8373603c5b302f2f 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -962,8 +962,14 @@ if (is_android) {
]
}
+ # Some android targets still depend on --gc-sections to link.
+ # TODO: remove --gc-sections for Debug builds (crbug.com/159847).
+ config("gc_sections") {
+ ldflags = [ "-Wl,--gc-sections" ]
+ }
+
# GYP: //chrome/chrome_android.gypi:chrome_android_core
- static_library("chrome_android_core") {
+ source_set("chrome_android_core") {
sources = [
"app/android/chrome_android_initializer.cc",
"app/android/chrome_android_initializer.h",
@@ -974,6 +980,7 @@ if (is_android) {
"app/chrome_main_delegate.cc",
"app/chrome_main_delegate.h",
]
+ public_configs = [ ":gc_sections" ]
include_dirs = [ android_ndk_include_dir ]
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698