Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1541113003: Revert of Change extension icon load errors to warnings (Closed)

Created:
5 years ago by Devlin
Modified:
4 years, 11 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change extension icon load errors to warnings (patchset #8 id:140001 of https://codereview.chromium.org/1537473003/ ) Reason for revert: caused crbug.com/571701 Original issue's description: > Change extension icon load errors to warnings > > During the Extension parsing step, check if the icon file exists and if not, remove that entry from the dictionary. > > Keep the same check during the validation phase and don't apply the workaround to unpacked extensions. This will more strongly discourage new extensions from making this mistake. > > BUG=570249 > > Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b > Cr-Commit-Position: refs/heads/master@{#366253} TBR=estade@chromium.org BUG=570249

Patch Set 1 #

Patch Set 2 : manual rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -203 lines) Patch
D chrome/browser/extensions/api/extension_action/browser_action_unittest.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M chrome/browser/extensions/extension_action_manager_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_test_with_install.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service_test_with_install.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc View 1 2 chunks +2 lines, -15 lines 0 comments Download
D chrome/test/data/extensions/api_test/browser_action/missing_icon/icon24.png View Binary file 0 comments Download
D chrome/test/data/extensions/api_test/browser_action/missing_icon/icon38.png View Binary file 0 comments Download
D chrome/test/data/extensions/api_test/browser_action/missing_icon/manifest.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/api_test/browser_action/multi_icons/icon19.png View Binary file 0 comments Download
D chrome/test/data/extensions/api_test/browser_action/multi_icons/icon24.png View Binary file 0 comments Download
D chrome/test/data/extensions/api_test/browser_action/multi_icons/icon38.png View Binary file 0 comments Download
D chrome/test/data/extensions/api_test/browser_action/multi_icons/manifest.json View 1 chunk +0 lines, -13 lines 0 comments Download
M extensions/common/file_util.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/common/file_util.cc View 1 2 chunks +12 lines, -5 lines 0 comments Download
M extensions/common/file_util_unittest.cc View 1 1 chunk +4 lines, -24 lines 0 comments Download
M extensions/common/manifest_handler_helpers.h View 1 3 chunks +2 lines, -9 lines 0 comments Download
M extensions/common/manifest_handler_helpers.cc View 1 3 chunks +3 lines, -22 lines 0 comments Download
M extensions/common/manifest_handlers/icons_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D extensions/test/data/file_util/bad_icon/good-icon.png View Binary file 0 comments Download
M extensions/test/data/file_util/bad_icon/manifest.json View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/utility/unpacker.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Devlin
Created Revert of Change extension icon load errors to warnings
5 years ago (2015-12-22 23:13:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541113003/1
5 years ago (2015-12-22 23:14:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/110944) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-12-22 23:17:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541113003/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541113003/260001
5 years ago (2015-12-23 06:50:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/131358)
5 years ago (2015-12-23 06:55:03 UTC) #10
Evan Stade
On 2015/12/23 06:55:03, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 11 months ago (2015-12-29 17:39:22 UTC) #11
Evan Stade
4 years, 11 months ago (2015-12-29 17:39:41 UTC) #12
On 2015/12/29 17:39:22, Evan Stade (ooo to Tues12-29) wrote:
> On 2015/12/23 06:55:03, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> https://codereview.chromium.org/1537473003/

err, revert here: https://codereview.chromium.org/1554583002/

Powered by Google App Engine
This is Rietveld 408576698