Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: extensions/common/manifest_handlers/icons_handler.cc

Issue 1541113003: Revert of Change extension icon load errors to warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: manual rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_handlers/icons_handler.cc
diff --git a/extensions/common/manifest_handlers/icons_handler.cc b/extensions/common/manifest_handlers/icons_handler.cc
index 52597e5b621327320b950aa84cb00d919ff3964c..20ad025b25ba879eaeb8dab1f3d86f4ceef92bc4 100644
--- a/extensions/common/manifest_handlers/icons_handler.cc
+++ b/extensions/common/manifest_handlers/icons_handler.cc
@@ -64,7 +64,7 @@ bool IconsHandler::Parse(Extension* extension, base::string16* error) {
}
if (!manifest_handler_helpers::LoadIconsFromDictionary(
- extension, icons_dict, &icons_info->icons, error)) {
+ icons_dict, &icons_info->icons, error)) {
return false;
}
« no previous file with comments | « extensions/common/manifest_handler_helpers.cc ('k') | extensions/test/data/file_util/bad_icon/good-icon.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698