[runtime] Rewrite Function.prototype.toString in C++.

[runtime] Rewrite Function.prototype.toString in C++.

There's actually no point trying to do Function.prototype.toString in
JavaScript, as it always calls into C++ at least once, so it only
complicates things (esp. once we start optimizing bound functions).

Drive-by-fix: Rename FunctionApply and FunctionCall builtins to also
reflect the fact that these are builtins in the Function.prototype and
not on Function itself.

TBR=hpayer@chromium.org
R=yangguo@chromium.org
BUG=chromium:535408
LOG=n

Committed: https://crrev.com/4acca53e62cdfe6f3c495c87ca7d3c8fe1059f01
Cr-Commit-Position: refs/heads/master@{#32996}

[Benedikt Meurer, 2015-12-22 05:59:15]

Description was changed from

==========
[runtime] Rewrite Function.prototype.toString in C++.

There's actually no point trying to do Function.prototype.toString in
JavaScript, as it always calls into C++ at least once, so it only
complicates things (esp. once we start optimizing bound functions).

Drive-by-fix: Rename FunctionApply and FunctionCall builtins to also
reflect the fact that these are builtins in the Function.prototype and
not on Function itself.

R=yangguo@chromium.org
BUG=chromium:535408
LOG=n
==========

to

==========
[runtime] Rewrite Function.prototype.toString in C++.

There's actually no point trying to do Function.prototype.toString in
JavaScript, as it always calls into C++ at least once, so it only
complicates things (esp. once we start optimizing bound functions).

Drive-by-fix: Rename FunctionApply and FunctionCall builtins to also
reflect the fact that these are builtins in the Function.prototype and
not on Function itself.

TBR=hpayer@chromium.org
R=yangguo@chromium.org
BUG=chromium:535408
LOG=n
==========

[Benedikt Meurer, 2015-12-22 06:01:11]

Hey Yang,

First part of yak shaving for Function.prototype.bind: Moving
Function.prototype.toString to C++, so we can properly deal with
JSBoundFunctions later w/o having to go through additional C++ helpers.
Also does some cleanup on the namings of the Function builtins.
Please take a look (src/heap is just one additional string, TBRed heap owner as
discussed last week).

Thanks,
Benedikt

[Yang, 2015-12-22 06:19:22]

awesome. lgtm with comment.

https://codereview.chromium.org/1540953004/diff/20001/src/debug/mirrors.js
File src/debug/mirrors.js (right):

https://codereview.chromium.org/1540953004/diff/20001/src/debug/mirrors.js#ne...
src/debug/mirrors.js:939: return %FunctionToString(this.value_);
Alternatively, you could import global.Function.prototype.toString at the start
of this file and use it here. Then you don't have to introduce this %-function.

[Benedikt Meurer, 2015-12-22 06:30:35]

https://codereview.chromium.org/1540953004/diff/20001/src/debug/mirrors.js
File src/debug/mirrors.js (right):

https://codereview.chromium.org/1540953004/diff/20001/src/debug/mirrors.js#ne...
src/debug/mirrors.js:939: return %FunctionToString(this.value_);
As per offline discussion: This doesn't work with the current bootstrapper
unfortunately because we need that in messages.js as well. So we'll keep it this
way instead for now.

[Benedikt Meurer, 2015-12-22 06:30:45]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-12-22 06:30:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1540953004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1540953004/20001

[commit-bot: I haz the power, 2015-12-22 06:32:53]

Description was changed from

==========
[runtime] Rewrite Function.prototype.toString in C++.

There's actually no point trying to do Function.prototype.toString in
JavaScript, as it always calls into C++ at least once, so it only
complicates things (esp. once we start optimizing bound functions).

Drive-by-fix: Rename FunctionApply and FunctionCall builtins to also
reflect the fact that these are builtins in the Function.prototype and
not on Function itself.

TBR=hpayer@chromium.org
R=yangguo@chromium.org
BUG=chromium:535408
LOG=n
==========

to

==========
[runtime] Rewrite Function.prototype.toString in C++.

There's actually no point trying to do Function.prototype.toString in
JavaScript, as it always calls into C++ at least once, so it only
complicates things (esp. once we start optimizing bound functions).

Drive-by-fix: Rename FunctionApply and FunctionCall builtins to also
reflect the fact that these are builtins in the Function.prototype and
not on Function itself.

TBR=hpayer@chromium.org
R=yangguo@chromium.org
BUG=chromium:535408
LOG=n
==========

[commit-bot: I haz the power, 2015-12-22 06:32:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-22 06:33:49]

Description was changed from

==========
[runtime] Rewrite Function.prototype.toString in C++.

There's actually no point trying to do Function.prototype.toString in
JavaScript, as it always calls into C++ at least once, so it only
complicates things (esp. once we start optimizing bound functions).

Drive-by-fix: Rename FunctionApply and FunctionCall builtins to also
reflect the fact that these are builtins in the Function.prototype and
not on Function itself.

TBR=hpayer@chromium.org
R=yangguo@chromium.org
BUG=chromium:535408
LOG=n
==========

to

==========
[runtime] Rewrite Function.prototype.toString in C++.

There's actually no point trying to do Function.prototype.toString in
JavaScript, as it always calls into C++ at least once, so it only
complicates things (esp. once we start optimizing bound functions).

Drive-by-fix: Rename FunctionApply and FunctionCall builtins to also
reflect the fact that these are builtins in the Function.prototype and
not on Function itself.

TBR=hpayer@chromium.org
R=yangguo@chromium.org
BUG=chromium:535408
LOG=n

Committed: https://crrev.com/4acca53e62cdfe6f3c495c87ca7d3c8fe1059f01
Cr-Commit-Position: refs/heads/master@{#32996}
==========

[commit-bot: I haz the power, 2015-12-22 06:33:50]

Patchset 2 (id:??) landed as
https://crrev.com/4acca53e62cdfe6f3c495c87ca7d3c8fe1059f01
Cr-Commit-Position: refs/heads/master@{#32996}