src/runtime/runtime-generator.cc - Issue 1540953004: [runtime] Rewrite Function.prototype.toString in C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-generator.cc

Issue 1540953004: [runtime] Rewrite Function.prototype.toString in C++. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix typos. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-generator.cc

diff --git a/src/runtime/runtime-generator.cc b/src/runtime/runtime-generator.cc

index 208f7f6680eeb05eb4db6100b3a2f0204469f23f..926cd3ce2d6d107e6b94bb2f3caa44cd1bd6cdc9 100644

--- a/src/runtime/runtime-generator.cc

+++ b/src/runtime/runtime-generator.cc

@@ -209,14 +209,6 @@ RUNTIME_FUNCTION(Runtime_GeneratorGetSourcePosition) {

}

-RUNTIME_FUNCTION(Runtime_FunctionIsGenerator) {

- SealHandleScope shs(isolate);

- DCHECK(args.length() == 1);

- CONVERT_ARG_CHECKED(JSFunction, f, 0);

- return isolate->heap()->ToBoolean(f->shared()->is_generator());

RUNTIME_FUNCTION(Runtime_GeneratorNext) {

UNREACHABLE(); // Optimization disabled in SetUpGenerators().

return NULL;