Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1540953002: NaCl: Expand comment about PpapiHostMsg_OpenResource in ppapi_messages.h (Closed)

Created:
5 years ago by Mark Seaborn
Modified:
5 years ago
Reviewers:
bbudge, Will Harris
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Expand comment about PpapiHostMsg_OpenResource in ppapi_messages.h BUG=302078 TEST=none Committed: https://crrev.com/38c234c3dd8008ebf47bd81a63f815ae4bd0d007 Cr-Commit-Position: refs/heads/master@{#366543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M ppapi/proxy/ppapi_messages.h View 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Mark Seaborn
I've split this out from https://codereview.chromium.org/1512733003/ to make it easier to review, and I've expanded ...
5 years ago (2015-12-21 18:58:23 UTC) #2
bbudge
LGTM
5 years ago (2015-12-21 19:03:44 UTC) #3
Mark Seaborn
+wfh for IPC message security review.
5 years ago (2015-12-21 22:30:56 UTC) #6
Will Harris
lgtm
5 years ago (2015-12-22 04:01:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540953002/1
5 years ago (2015-12-22 04:02:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-22 04:48:01 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-22 04:48:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38c234c3dd8008ebf47bd81a63f815ae4bd0d007
Cr-Commit-Position: refs/heads/master@{#366543}

Powered by Google App Engine
This is Rietveld 408576698