Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: ppapi/proxy/ppapi_messages.h

Issue 1540953002: NaCl: Expand comment about PpapiHostMsg_OpenResource in ppapi_messages.h (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/ppapi_messages.h
diff --git a/ppapi/proxy/ppapi_messages.h b/ppapi/proxy/ppapi_messages.h
index 3bc0d5fe694fe275c3f1911f8070010850c7b8fd..c332a9d73ecf0f878727e3f7a8a0c68760c34566 100644
--- a/ppapi/proxy/ppapi_messages.h
+++ b/ppapi/proxy/ppapi_messages.h
@@ -884,7 +884,20 @@ IPC_MESSAGE_CONTROL1(PpapiHostMsg_ChannelCreated,
// Notify the renderer that the PPAPI channel gets ready in the plugin.
IPC_MESSAGE_CONTROL0(PpapiHostMsg_StartupInitializationComplete)
-// Calls renderer to open a resource file for nacl_irt_open_resource().
+// This is sent from a nexe (NaCl untrusted code) to the renderer, to open a
+// file listed in a NaCl manifest file (NMF). It is part of the
+// implementation of open_resource(), which is defined in NaCl's irt.h.
+//
+// This call returns a read-only file handle from the renderer. When using
+// validation caching, this handle is not used: The NaCl loader process will
+// reacquire the handle from the more-trusted browser process via
+// NaClProcessMsg_ResolveFileToken, passing the token values returned here.
+//
+// Note that the open_resource() interface is not a PPAPI interface (in the
+// sense that it's not defined in ppapi/c/), but this message is defined here
+// in ppapi_messages.h (rather than in components/nacl/) because half of the
+// implementation of open_resource() lives in ppapi/nacl_irt/, and because
+// this message must be processed by ppapi/proxy/nacl_message_scanner.cc.
IPC_SYNC_MESSAGE_CONTROL1_3(PpapiHostMsg_OpenResource,
std::string /* key */,
ppapi::proxy::SerializedHandle /* fd */,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698