Issue 1540613002: Center static icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1540613002: Center static icon (Closed)

Created:
5 years ago by mdjones

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

Center static icon Add a maximum icon width for the ContextualSearchLayer and use it to center the static icon. The max icon size is in dp, so the current value of dp-to-px needs to be passed to native. BUG=570407 Review URL: https://codereview.chromium.org/1535753002 Cr-Commit-Position: refs/heads/master@{#365985} (cherry picked from commit fa697899c4fe9e0f9bd2aa9457a945a2ccbdaff6) Committed: https://chromium.googlesource.com/chromium/src/+/b29eb695e2a000d4b8560ebf6b268d8d9b6ca840

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -2 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/android/compositor/layer/contextual_search_layer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/android/compositor/layer/contextual_search_layer.cc	View	3 chunks	+12 lines, -2 lines	0 comments	Download
M	chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

mdjones

5 years ago (2015-12-18 18:03:30 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b29eb695e2a000d4b8560ebf6b268d8d9b6ca840.