Center static icon

Center static icon

Add a maximum icon width for the ContextualSearchLayer and use it
to center the static icon. The max icon size is in dp, so the current
value of dp-to-px needs to be passed to native.

BUG=570407
Committed: https://crrev.com/fa697899c4fe9e0f9bd2aa9457a945a2ccbdaff6
Cr-Commit-Position: refs/heads/master@{#365985}

[mdjones, 2015-12-17 23:11:29]

Description was changed from

==========
Center static icon

Add a maximum icon width for the ContextualSearchLayer and use it
to center the static icon. The max icon size is in dp, so the current
value of dp-to-px needs to be passed to native.

BUG=570407
==========

to

==========
Center static icon

Add a maximum icon width for the ContextualSearchLayer and use it
to center the static icon. The max icon size is in dp, so the current
value of dp-to-px needs to be passed to native.

BUG=570407
==========

[mdjones, 2015-12-17 23:11:29]

mdjones@chromium.org changed reviewers:
+ pedrosimonetti@chromium.org

[mdjones, 2015-12-17 23:39:54]

PTAL

[pedro (no code reviews), 2015-12-17 23:52:25]

lgtm

https://codereview.chromium.org/1535753002/diff/20001/chrome/browser/android/...
File chrome/browser/android/compositor/layer/contextual_search_layer.cc (right):

https://codereview.chromium.org/1535753002/diff/20001/chrome/browser/android/...
chrome/browser/android/compositor/layer/contextual_search_layer.cc:32: // This
is the default width for any static icon displayed on an OverlayPanel.
Nit: remove "static" since we could use "dynamic" resource icons, or "crushed
png" icons.

[mdjones, 2015-12-18 01:20:40]

https://codereview.chromium.org/1535753002/diff/20001/chrome/browser/android/...
File chrome/browser/android/compositor/layer/contextual_search_layer.cc (right):

https://codereview.chromium.org/1535753002/diff/20001/chrome/browser/android/...
chrome/browser/android/compositor/layer/contextual_search_layer.cc:32: // This
is the default width for any static icon displayed on an OverlayPanel.
On 2015/12/17 23:52:25, pedrosimonetti wrote:
> Nit: remove "static" since we could use "dynamic" resource icons, or "crushed
> png" icons.

Done.

[gone, 2015-12-18 01:27:14]

dfalcantara@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2015-12-18 01:27:15]

lgtm

That is a frightening number of function parameters.  Hope you don't get them
mixed up at some point.

[mdjones, 2015-12-18 01:29:58]

On 2015/12/18 01:27:15, dfalcantara wrote:
> lgtm
> 
> That is a frightening number of function parameters.  Hope you don't get them
> mixed up at some point.

That situation is a work in progress :)

[mdjones, 2015-12-18 01:30:05]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2015-12-18 01:30:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
pedrosimonetti@chromium.org
Link to the patchset: https://codereview.chromium.org/1535753002/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2015-12-18 01:33:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1535753002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1535753002/40001

[commit-bot: I haz the power, 2015-12-18 02:17:23]

Description was changed from

==========
Center static icon

Add a maximum icon width for the ContextualSearchLayer and use it
to center the static icon. The max icon size is in dp, so the current
value of dp-to-px needs to be passed to native.

BUG=570407
==========

to

==========
Center static icon

Add a maximum icon width for the ContextualSearchLayer and use it
to center the static icon. The max icon size is in dp, so the current
value of dp-to-px needs to be passed to native.

BUG=570407
==========

[commit-bot: I haz the power, 2015-12-18 02:17:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-18 02:19:14]

Description was changed from

==========
Center static icon

Add a maximum icon width for the ContextualSearchLayer and use it
to center the static icon. The max icon size is in dp, so the current
value of dp-to-px needs to be passed to native.

BUG=570407
==========

to

==========
Center static icon

Add a maximum icon width for the ContextualSearchLayer and use it
to center the static icon. The max icon size is in dp, so the current
value of dp-to-px needs to be passed to native.

BUG=570407

Committed: https://crrev.com/fa697899c4fe9e0f9bd2aa9457a945a2ccbdaff6
Cr-Commit-Position: refs/heads/master@{#365985}
==========

[commit-bot: I haz the power, 2015-12-18 02:19:15]

Patchset 3 (id:??) landed as
https://crrev.com/fa697899c4fe9e0f9bd2aa9457a945a2ccbdaff6
Cr-Commit-Position: refs/heads/master@{#365985}