 Chromium Code Reviews
 Chromium Code Reviews Issue 1540463003:
  Change the interface of GetAlternativeServicesFor, always return the best Alt-Svc entry.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1540463003:
  Change the interface of GetAlternativeServicesFor, always return the best Alt-Svc entry.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: net/quic/test_tools/quic_test_packet_maker.h | 
| diff --git a/net/quic/test_tools/quic_test_packet_maker.h b/net/quic/test_tools/quic_test_packet_maker.h | 
| index 6609f511f0dacd66907f1bdc4093b5ddb6c071dd..0cd4b401f55e6f8a1ca2839ab04e5ffed648973a 100644 | 
| --- a/net/quic/test_tools/quic_test_packet_maker.h | 
| +++ b/net/quic/test_tools/quic_test_packet_maker.h | 
| @@ -55,6 +55,12 @@ class QuicTestPacketMaker { | 
| QuicPacketNumber largest_received, | 
| QuicPacketNumber least_unacked, | 
| bool send_feedback); | 
| + scoped_ptr<QuicEncryptedPacket> MakeAckPacket( | 
| 
Ryan Hamilton
2015/12/30 21:51:41
Can you add comments which explain how the previou
 
Zhongyi Shi
2016/01/05 22:54:20
Done.
 | 
| + QuicPacketNumber packet_number, | 
| + QuicPacketNumber largest_received, | 
| + QuicPacketNumber ack_least_unacked, | 
| + QuicPacketNumber stop_least_unacked, | 
| + bool send_feedback); | 
| scoped_ptr<QuicEncryptedPacket> MakeDataPacket(QuicPacketNumber packet_number, | 
| QuicStreamId stream_id, | 
| bool should_include_version, | 
| @@ -73,6 +79,16 @@ class QuicTestPacketMaker { | 
| const SpdyHeaderBlock& headers, | 
| size_t* spdy_headers_frame_length); | 
| + scoped_ptr<QuicEncryptedPacket> MakeRequestHeadersPacket( | 
| + QuicPacketNumber packet_number, | 
| + QuicStreamId stream_id, | 
| + bool should_include_version, | 
| + bool fin, | 
| + SpdyPriority priority, | 
| + const SpdyHeaderBlock& headers, | 
| + size_t* spdy_headers_frame_length, | 
| + QuicStreamOffset offset); | 
| + | 
| // Convenience method for calling MakeRequestHeadersPacket with nullptr for | 
| // |spdy_headers_frame_length|. | 
| scoped_ptr<QuicEncryptedPacket> MakeRequestHeadersPacket( | 
| @@ -81,7 +97,8 @@ class QuicTestPacketMaker { | 
| bool should_include_version, | 
| bool fin, | 
| SpdyPriority priority, | 
| - const SpdyHeaderBlock& headers); | 
| + const SpdyHeaderBlock& headers, | 
| + QuicStreamOffset offset); | 
| // If |spdy_headers_frame_length| is non-null, it will be set to the size of | 
| // the SPDY headers frame created for this packet. | 
| @@ -91,6 +108,15 @@ class QuicTestPacketMaker { | 
| bool should_include_version, | 
| bool fin, | 
| const SpdyHeaderBlock& headers, | 
| + size_t* spdy_headers_frame_length, | 
| + QuicStreamOffset offset); | 
| + | 
| + scoped_ptr<QuicEncryptedPacket> MakeResponseHeadersPacket( | 
| + QuicPacketNumber packet_number, | 
| + QuicStreamId stream_id, | 
| + bool should_include_version, | 
| + bool fin, | 
| + const SpdyHeaderBlock& headers, | 
| size_t* spdy_headers_frame_length); | 
| // Convenience method for calling MakeResponseHeadersPacket with nullptr for | 
| @@ -100,7 +126,8 @@ class QuicTestPacketMaker { | 
| QuicStreamId stream_id, | 
| bool should_include_version, | 
| bool fin, | 
| - const SpdyHeaderBlock& headers); | 
| + const SpdyHeaderBlock& headers, | 
| + QuicStreamOffset offset); | 
| SpdyHeaderBlock GetRequestHeaders(const std::string& method, | 
| const std::string& scheme, |