Change the interface of GetAlternativeServicesFor, always return the best Alt-Svc entry.

net/quic/test_tools/quic_test_packet_maker.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Provides a simple interface for QUIC tests to create a variety of packets.
 
 #ifndef NET_QUIC_TEST_TOOLS_QUIC_TEST_PACKET_MAKER_H_
 #define NET_QUIC_TEST_TOOLS_QUIC_TEST_PACKET_MAKER_H_
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 37 matching lines @@
       QuicPacketNumber least_unacked,
       QuicErrorCode quic_error,
       std::string& quic_error_details);
   scoped_ptr<QuicEncryptedPacket> MakeConnectionClosePacket(
       QuicPacketNumber num);
   scoped_ptr<QuicEncryptedPacket> MakeAckPacket(
       QuicPacketNumber packet_number,
       QuicPacketNumber largest_received,
       QuicPacketNumber least_unacked,
       bool send_feedback);
+  scoped_ptr<QuicEncryptedPacket> MakeAckPacket(

[Ryan Hamilton, 2015/12/30 21:51:41]

Can you add comments which explain how the previous method interacts with this
one?

[Zhongyi Shi, 2016/01/05 22:54:20]

Done.

+      QuicPacketNumber packet_number,
+      QuicPacketNumber largest_received,
+      QuicPacketNumber ack_least_unacked,
+      QuicPacketNumber stop_least_unacked,
+      bool send_feedback);
   scoped_ptr<QuicEncryptedPacket> MakeDataPacket(QuicPacketNumber packet_number,
                                                  QuicStreamId stream_id,
                                                  bool should_include_version,
                                                  bool fin,
                                                  QuicStreamOffset offset,
                                                  base::StringPiece data);
 
   // If |spdy_headers_frame_length| is non-null, it will be set to the size of
   // the SPDY headers frame created for this packet.
   scoped_ptr<QuicEncryptedPacket> MakeRequestHeadersPacket(
       QuicPacketNumber packet_number,
       QuicStreamId stream_id,
       bool should_include_version,
       bool fin,
       SpdyPriority priority,
       const SpdyHeaderBlock& headers,
       size_t* spdy_headers_frame_length);
 
+  scoped_ptr<QuicEncryptedPacket> MakeRequestHeadersPacket(
+      QuicPacketNumber packet_number,
+      QuicStreamId stream_id,
+      bool should_include_version,
+      bool fin,
+      SpdyPriority priority,
+      const SpdyHeaderBlock& headers,
+      size_t* spdy_headers_frame_length,
+      QuicStreamOffset offset);
+
   // Convenience method for calling MakeRequestHeadersPacket with nullptr for
   // |spdy_headers_frame_length|.
   scoped_ptr<QuicEncryptedPacket> MakeRequestHeadersPacket(
       QuicPacketNumber packet_number,
       QuicStreamId stream_id,
       bool should_include_version,
       bool fin,
       SpdyPriority priority,
-      const SpdyHeaderBlock& headers);
+      const SpdyHeaderBlock& headers,
+      QuicStreamOffset offset);
 
   // If |spdy_headers_frame_length| is non-null, it will be set to the size of
   // the SPDY headers frame created for this packet.
   scoped_ptr<QuicEncryptedPacket> MakeResponseHeadersPacket(
       QuicPacketNumber packet_number,
       QuicStreamId stream_id,
       bool should_include_version,
       bool fin,
       const SpdyHeaderBlock& headers,
+      size_t* spdy_headers_frame_length,
+      QuicStreamOffset offset);
+
+  scoped_ptr<QuicEncryptedPacket> MakeResponseHeadersPacket(
+      QuicPacketNumber packet_number,
+      QuicStreamId stream_id,
+      bool should_include_version,
+      bool fin,
+      const SpdyHeaderBlock& headers,
       size_t* spdy_headers_frame_length);
 
   // Convenience method for calling MakeResponseHeadersPacket with nullptr for
   // |spdy_headers_frame_length|.
   scoped_ptr<QuicEncryptedPacket> MakeResponseHeadersPacket(
       QuicPacketNumber packet_number,
       QuicStreamId stream_id,
       bool should_include_version,
       bool fin,
-      const SpdyHeaderBlock& headers);
+      const SpdyHeaderBlock& headers,
+      QuicStreamOffset offset);
 
   SpdyHeaderBlock GetRequestHeaders(const std::string& method,
                                     const std::string& scheme,
                                     const std::string& path);
   SpdyHeaderBlock GetResponseHeaders(const std::string& status);
 
  private:
   scoped_ptr<QuicEncryptedPacket> MakePacket(
       const QuicPacketHeader& header,
       const QuicFrame& frame);
@@ skipping 10 matching lines @@
   MockRandom random_generator_;
   QuicPacketHeader header_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicTestPacketMaker);
 };
 
 }  // namespace test
 }  // namespace net
 
 #endif  // NET_QUIC_TEST_TOOLS_QUIC_TEST_PACKET_MAKER_H_