Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1540363002: Don't ref/unref the static src-over xp (Closed)

Created:
5 years ago by bsalomon
Modified:
5 years ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add comments #

Patch Set 3 : tiny #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -33 lines) Patch
M include/gpu/effects/GrPorterDuffXferProcessor.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/GrPipeline.h View 1 2 chunks +10 lines, -2 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 1 2 4 chunks +22 lines, -20 lines 0 comments Download
M src/gpu/batches/GrDrawBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 2 chunks +11 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
bsalomon
5 years ago (2015-12-21 20:44:49 UTC) #3
egdaniel
lgtm
5 years ago (2015-12-21 20:55:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1540363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1540363002/40001
5 years ago (2015-12-21 20:58:18 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-21 21:12:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2047b7855546b21f7956c398592c070b3f91a9db

Powered by Google App Engine
This is Rietveld 408576698