Support some file operations in dart:io under mojo

Support some file operations in dart:io under mojo

- Implement File.create and File.exists.
- Implement Directory.create and Directory.exists.
- Implement Directory.systemTemp and Directory.createTemp.
- Fix existing directory logic bug in mojo:files service.
- Unit tests for implemented functions.

R=zra@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/2c2b5c8c073293b96cad529dcf8f28d58683fd24

[Cutch, 2015-12-18 22:03:49]

Description was changed from

==========
Some support for files in dart:io under mojo
==========

to

==========
Some support for files in dart:io under mojo

- Implement File.create and File.exists.
- Implement Directory.create and Directory.exists.
- Implement Directory.systemTemp and Directory.createTemp.
- Fix existing directory logic bug in mojo:files service.
- Unit tests for implemented functions.
==========

[Cutch, 2015-12-18 22:03:49]

johnmccutchan@google.com changed reviewers:
+ vtl@google.com, zra@google.com

[Cutch, 2015-12-18 22:04:08]

Description was changed from

==========
Some support for files in dart:io under mojo

- Implement File.create and File.exists.
- Implement Directory.create and Directory.exists.
- Implement Directory.systemTemp and Directory.createTemp.
- Fix existing directory logic bug in mojo:files service.
- Unit tests for implemented functions.
==========

to

==========
Support some file operations in dart:io under mojo

- Implement File.create and File.exists.
- Implement Directory.create and Directory.exists.
- Implement Directory.systemTemp and Directory.createTemp.
- Fix existing directory logic bug in mojo:files service.
- Unit tests for implemented functions.
==========

[viettrungluu, 2015-12-18 22:10:38]

viettrungluu@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[viettrungluu, 2015-12-18 22:10:38]

https://codereview.chromium.org/1539843004/diff/20001/services/files/director...
File services/files/directory_impl.cc (right):

https://codereview.chromium.org/1539843004/diff/20001/services/files/director...
services/files/directory_impl.cc:1: // Copyright 2015 The Chromium Authors. All
rights reserved.
This file lg to me. I'll leave it to zra to review the rest, I guess?

https://codereview.chromium.org/1539843004/diff/20001/services/files/director...
services/files/directory_impl.cc:265: if ((errno != EEXIST) || (open_flags &
kOpenFlagExclusive)) {
D'oh. I guess I should write a test for this case....

[zra, 2015-12-18 22:51:46]

https://codereview.chromium.org/1539843004/diff/20001/mojo/dart/embedder/io/f...
File mojo/dart/embedder/io/file_patch.dart (right):

https://codereview.chromium.org/1539843004/diff/20001/mojo/dart/embedder/io/f...
mojo/dart/embedder/io/file_patch.dart:45: await
rootDirectory.ptr.openDirectory(_ensurePathIsRelative(path),
For IPC calls deep in library implementations, it might be best to wrap them in
e.g. rootDirectory.responseOrError() and throw an exception rather than the
Future returned by create() never completing.

https://codereview.chromium.org/1539843004/diff/20001/mojo/dart/embedder/io/f...
mojo/dart/embedder/io/file_patch.dart:61: print(tempPath);
debug print?

https://codereview.chromium.org/1539843004/diff/20001/mojo/dart/embedder/io/f...
mojo/dart/embedder/io/file_patch.dart:62: var response = await
rootDirectory.ptr.openDirectory(tempPath, null, flags);
long line

https://codereview.chromium.org/1539843004/diff/20001/mojo/dart/embedder/io/f...
mojo/dart/embedder/io/file_patch.dart:93: /* patch */ static _createTemp(String
path) {
What are these empty functions for? Should they throw some sort of Unimplemented
exception?

https://codereview.chromium.org/1539843004/diff/20001/mojo/dart/embedder/io/m...
File mojo/dart/embedder/io/mojo_patch.dart (right):

https://codereview.chromium.org/1539843004/diff/20001/mojo/dart/embedder/io/m...
mojo/dart/embedder/io/mojo_patch.dart:138: var response = await
files.ptr.openFileSystem('app_persistent_cache', _rootDirectory);
long line

https://codereview.chromium.org/1539843004/diff/20001/services/dart/dart_appt...
File services/dart/dart_apptests/lib/src/file_apptests.dart (right):

https://codereview.chromium.org/1539843004/diff/20001/services/dart/dart_appt...
services/dart/dart_apptests/lib/src/file_apptests.dart:22: expect(new
File(relative).absolute.path, '$current$relative');
Is this shorthand for expect(x, equals(y))?

[Cutch, 2015-12-18 23:05:20]

https://codereview.chromium.org/1539843004/diff/20001/mojo/dart/embedder/io/f...
File mojo/dart/embedder/io/file_patch.dart (right):

https://codereview.chromium.org/1539843004/diff/20001/mojo/dart/embedder/io/f...
mojo/dart/embedder/io/file_patch.dart:45: await
rootDirectory.ptr.openDirectory(_ensurePathIsRelative(path),
On 2015/12/18 22:51:46, zra wrote:
> For IPC calls deep in library implementations, it might be best to wrap them
in
> e.g. rootDirectory.responseOrError() and throw an exception rather than the
> Future returned by create() never completing.

Done here and elsewhere.

https://codereview.chromium.org/1539843004/diff/20001/mojo/dart/embedder/io/f...
mojo/dart/embedder/io/file_patch.dart:61: print(tempPath);
On 2015/12/18 22:51:46, zra wrote:
> debug print?

Done.

https://codereview.chromium.org/1539843004/diff/20001/mojo/dart/embedder/io/f...
mojo/dart/embedder/io/file_patch.dart:62: var response = await
rootDirectory.ptr.openDirectory(tempPath, null, flags);
On 2015/12/18 22:51:46, zra wrote:
> long line

Done.

https://codereview.chromium.org/1539843004/diff/20001/mojo/dart/embedder/io/f...
mojo/dart/embedder/io/file_patch.dart:93: /* patch */ static _createTemp(String
path) {
On 2015/12/18 22:51:46, zra wrote:
> What are these empty functions for? Should they throw some sort of
Unimplemented
> exception?

These are patches that will be necessary. I've added unimplemented errors to
each of them.

https://codereview.chromium.org/1539843004/diff/20001/mojo/dart/embedder/io/m...
File mojo/dart/embedder/io/mojo_patch.dart (right):

https://codereview.chromium.org/1539843004/diff/20001/mojo/dart/embedder/io/m...
mojo/dart/embedder/io/mojo_patch.dart:138: var response = await
files.ptr.openFileSystem('app_persistent_cache', _rootDirectory);
On 2015/12/18 22:51:46, zra wrote:
> long line

Done.

https://codereview.chromium.org/1539843004/diff/20001/services/dart/dart_appt...
File services/dart/dart_apptests/lib/src/file_apptests.dart (right):

https://codereview.chromium.org/1539843004/diff/20001/services/dart/dart_appt...
services/dart/dart_apptests/lib/src/file_apptests.dart:22: expect(new
File(relative).absolute.path, '$current$relative');
On 2015/12/18 22:51:46, zra wrote:
> Is this shorthand for expect(x, equals(y))?

yes

[zra, 2015-12-18 23:11:59]

lgtm

[Cutch, 2015-12-18 23:13:48]

Description was changed from

==========
Support some file operations in dart:io under mojo

- Implement File.create and File.exists.
- Implement Directory.create and Directory.exists.
- Implement Directory.systemTemp and Directory.createTemp.
- Fix existing directory logic bug in mojo:files service.
- Unit tests for implemented functions.
==========

to

==========
Support some file operations in dart:io under mojo

- Implement File.create and File.exists.
- Implement Directory.create and Directory.exists.
- Implement Directory.systemTemp and Directory.createTemp.
- Fix existing directory logic bug in mojo:files service.
- Unit tests for implemented functions.

R=zra@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/2c2b5c8c073293b96cad529dcf8...
==========

[Cutch, 2015-12-18 23:13:49]

Committed patchset #3 (id:40001) manually as
2c2b5c8c073293b96cad529dcf8f28d58683fd24 (presubmit successful).