Support some file operations in dart:io under mojo

services/files/directory_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.

[viettrungluu, 2015/12/18 22:10:38]

This file lg to me. I'll leave it to zra to review the rest, I guess?

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/files/directory_impl.h"
 
 #include <dirent.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>
 #include <sys/stat.h>
@@ skipping 243 matching lines @@
   if (!(open_flags & kOpenFlagWrite)) {
     callback.Run(Error::UNIMPLEMENTED);
     return;
   }
 
   if ((open_flags & kOpenFlagCreate)) {
     if (mkdirat(dir_fd_.get(), path.get().c_str(), 0700) != 0) {
       // Allow |EEXIST| if |kOpenFlagExclusive| is not set. Note, however, that
       // it does not guarantee that |path| is a directory.
       // TODO(vtl): Hrm, ponder if we should check that |path| is a directory.
-      if (errno != EEXIST || !(open_flags & kOpenFlagExclusive)) {
+      if ((errno != EEXIST) || (open_flags & kOpenFlagExclusive)) {

[viettrungluu, 2015/12/18 22:10:38]

D'oh. I guess I should write a test for this case....

         callback.Run(ErrnoToError(errno));
         return;
       }
     }
   }
 
   base::ScopedFD new_dir_fd(
       HANDLE_EINTR(openat(dir_fd_.get(), path.get().c_str(), O_DIRECTORY, 0)));
   if (!new_dir_fd.is_valid()) {
     callback.Run(ErrnoToError(errno));
@@ skipping 77 matching lines @@
   if (unlinkat(dir_fd_.get(), path.get().c_str(), AT_REMOVEDIR) == 0) {
     callback.Run(Error::OK);
     return;
   }
 
   callback.Run(ErrnoToError(errno));
 }
 
 }  // namespace files
 }  // namespace mojo