Issue 1539813002: bindings: Fixes [LenientThis] to refer to the correct object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1539813002: bindings: Fixes [LenientThis] to refer to the correct object. (Closed)

Created:
5 years ago by Yuki

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

bindings: Fixes [LenientThis] to refer to the correct object. The info.Holder() and info.This() can be totally different objects. Fixes [LenientThis] to refer to info.Holder() which is the correct receiver object. BUG=569043 Review URL: https://codereview.chromium.org/1526833003 Cr-Commit-Position: refs/heads/master@{#365748} (cherry picked from commit 6097f83d40e2e3702bebb49d251100bb93478b0b) Committed: https://chromium.googlesource.com/chromium/src/+/ceb1bcab6b26dec5e31968e51866302d973366fa

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -20 lines)			Patch
A	third_party/WebKit/LayoutTests/fast/dom/Window/lenient-this-issue569043.html	View	1 chunk	+33 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/fast/dom/Window/lenient-this-issue569043-expected.txt	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/bindings/templates/attributes.cpp	View	2 chunks	+6 lines, -12 lines	0 comments	Download
M	third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp	View	2 chunks	+4 lines, -8 lines	0 comments	Download

Total messages: 2 (1 generated)

Yuki

5 years ago (2015-12-18 06:30:38 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ceb1bcab6b26dec5e31968e51866302d973366fa.