Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1526833003: bindings: Fixes [LenientThis] to refer to the correct object. (Closed)

Created:
5 years ago by Yuki
Modified:
5 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, jochen (gone - plz use gerrit), Toon Verwaest
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Fixes [LenientThis] to refer to the correct object. The info.Holder() and info.This() can be totally different objects. Fixes [LenientThis] to refer to info.Holder() which is the correct receiver object. BUG=569043 Committed: https://crrev.com/6097f83d40e2e3702bebb49d251100bb93478b0b Cr-Commit-Position: refs/heads/master@{#365748}

Patch Set 1 #

Patch Set 2 : Added a layout test. #

Patch Set 3 : Synced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -20 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/Window/lenient-this-issue569043.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/Window/lenient-this-issue569043-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/attributes.cpp View 2 chunks +6 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yuki
Could you review this CL? (cc'ing to jochen@ and verwaest@.)
5 years ago (2015-12-16 05:24:30 UTC) #2
haraken
The change looks good. Can you add a test?
5 years ago (2015-12-16 05:26:48 UTC) #3
Yuki
Added a layout test. Could you take another look?
5 years ago (2015-12-17 02:53:57 UTC) #4
haraken
LGTM
5 years ago (2015-12-17 03:04:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526833003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526833003/40001
5 years ago (2015-12-17 04:16:35 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-17 05:23:34 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-17 05:24:30 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6097f83d40e2e3702bebb49d251100bb93478b0b
Cr-Commit-Position: refs/heads/master@{#365748}

Powered by Google App Engine
This is Rietveld 408576698