[WebsiteSettings] Adjust visual margins on permission bubble to match mocks.

[WebsiteSettings] Adjust visual margins on permission bubble to match mocks.

R=markusheinz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251246

[markusheintz_, 2014-02-12 16:52:48]

LGTM

https://codereview.chromium.org/153973005/diff/1/chrome/browser/ui/views/webs...
File chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
(right):

https://codereview.chromium.org/153973005/diff/1/chrome/browser/ui/views/webs...
chrome/browser/ui/views/website_settings/permissions_bubble_view.cc:71:
views::BoxLayout::kVertical, 12, 0, 10));
I actually think it would be better to introduce consts here instead of using
plain number values.

This was the recommendation I received in the past and I think it makes the code
easier to understand.

[Greg Billock, 2014-02-13 21:43:39]

https://codereview.chromium.org/153973005/diff/1/chrome/browser/ui/views/webs...
File chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
(right):

https://codereview.chromium.org/153973005/diff/1/chrome/browser/ui/views/webs...
chrome/browser/ui/views/website_settings/permissions_bubble_view.cc:71:
views::BoxLayout::kVertical, 12, 0, 10));
On 2014/02/12 16:52:48, markusheintz_ wrote:
> I actually think it would be better to introduce consts here instead of using
> plain number values.
> 
> This was the recommendation I received in the past and I think it makes the
code
> easier to understand.

Yeah, I'll do that. Unfortunately the numbers don't make any sense given the
title spacing and bubble borders. :-/

[Greg Billock, 2014-02-13 21:43:47]

The CQ bit was checked by gbillock@chromium.org

[commit-bot: I haz the power, 2014-02-13 21:49:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/153973005/80001

[commit-bot: I haz the power, 2014-02-14 03:54:25]

Change committed as 251246