[WebsiteSettings] Adjust visual margins on permission bubble to match mocks.

chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/website_settings/permissions_bubble_view.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/website_settings/permission_bubble_request.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 50 matching lines @@
     : views::BubbleDelegateView(anchor, views::BubbleBorder::TOP_LEFT),
       owner_(owner),
       allow_(NULL),
       deny_(NULL),
       customize_(NULL) {
   RemoveAllChildViews(true);
   set_close_on_esc(false);
   set_close_on_deactivate(false);
 
   SetLayoutManager(new views::BoxLayout(
-      views::BoxLayout::kVertical, 30, 0, 20));
+      views::BoxLayout::kVertical, 12, 0, 10));

[markusheintz_, 2014/02/12 16:52:48]

I actually think it would be better to introduce consts here instead of using
plain number values.

This was the recommendation I received in the past and I think it makes the code
easier to understand.

[Greg Billock, 2014/02/13 21:43:39]

Yeah, I'll do that. Unfortunately the numbers don't make any sense given the
title spacing and bubble borders. :-/

 
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
 
   if (requests.size() == 1) {
     title_ = requests[0]->GetMessageText();
     if (GetWidget())
       GetWidget()->UpdateWindowTitle();
   } else {
     for (std::vector<PermissionBubbleRequest*>::const_iterator it =
              requests.begin();
@@ skipping 17 matching lines @@
   }
 
   views::View* button_row = new views::View();
   views::GridLayout* button_layout = new views::GridLayout(button_row);
   views::ColumnSet* columns = button_layout->AddColumnSet(0);
   columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::CENTER,
                      100.0, views::GridLayout::USE_PREF, 0, 0);
   columns->AddColumn(views::GridLayout::TRAILING, views::GridLayout::FILL,
                      0, views::GridLayout::USE_PREF, 0, 0);
   if (!customization_mode) {
-    columns->AddPaddingColumn(0, 10);  // padding between buttons
+    columns->AddPaddingColumn(0, 6);  // padding between buttons
     columns->AddColumn(views::GridLayout::TRAILING, views::GridLayout::FILL,
                        0, views::GridLayout::USE_PREF, 0, 0);
   }
 
   button_row->SetLayoutManager(button_layout);
   AddChildView(button_row);
 
   button_layout->StartRow(0, 0);
 
   // Customization case: empty "Customize" label and an "OK" button
@@ skipping 43 matching lines @@
   deny_button->SetFontList(rb.GetFontList(ui::ResourceBundle::MediumFont));
   button_layout->AddView(deny_button);
   deny_ = deny_button;
 
   views::LabelButton* allow_button = new views::LabelButton(this, allow_text);
   allow_button->SetStyle(views::Button::STYLE_BUTTON);
   allow_button->SetFontList(rb.GetFontList(ui::ResourceBundle::MediumFont));
   button_layout->AddView(allow_button);
   allow_ = allow_button;
 
-  button_layout->AddPaddingRow(0, 30);
+  button_layout->AddPaddingRow(0, 12);
 }
 
 PermissionsBubbleDelegateView::~PermissionsBubbleDelegateView() {
   if (owner_)
     owner_->Closing();
 }
 
 void PermissionsBubbleDelegateView::ResetOwner() {
   owner_ = NULL;
 }
@@ skipping 95 matching lines @@
 
 void PermissionBubbleViewViews::Deny() {
   if (delegate_)
     delegate_->Deny();
 }
 
 void PermissionBubbleViewViews::SetCustomizationMode() {
   if (delegate_)
     delegate_->SetCustomizationMode();
 }