Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1539703002: [Tracing] Remove context_id in favor of traits (Closed)

Created:
5 years ago by fmeawad
Modified:
5 years ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, darin-cc_chromium.org, jam, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Tracing] Remove context_id in favor of traits This CL also changes on the ContextId function to become a BindId function, to allow easier integation with third_party tracing integration. BUG=570851 Committed: https://crrev.com/e421277aa047bcbf61c965a57f1eb02dc1a582a2 Cr-Commit-Position: refs/heads/master@{#366123}

Patch Set 1 #

Patch Set 2 : Undo some git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -92 lines) Patch
M base/trace_event/trace_event.h View 22 chunks +42 lines, -60 lines 0 comments Download
M base/trace_event/trace_event_impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M base/trace_event/trace_event_impl.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M base/trace_event/trace_log.h View 3 chunks +2 lines, -4 lines 0 comments Download
M base/trace_event/trace_log.cc View 1 11 chunks +3 lines, -13 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
fmeawad
PTAL.
5 years ago (2015-12-17 23:49:13 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539703002/1
5 years ago (2015-12-17 23:49:49 UTC) #4
oystein (OOO til 10th of July)
lgtm, awesome :D
5 years ago (2015-12-18 00:03:35 UTC) #5
fmeawad
+ pfeldman for content/child/blink_platform_impl.cc
5 years ago (2015-12-18 00:06:37 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539703002/20001
5 years ago (2015-12-18 00:12:27 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-18 02:13:26 UTC) #11
pfeldman
lgtm
5 years ago (2015-12-18 17:56:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539703002/20001
5 years ago (2015-12-18 17:57:43 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-18 18:04:26 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-18 18:05:10 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e421277aa047bcbf61c965a57f1eb02dc1a582a2
Cr-Commit-Position: refs/heads/master@{#366123}

Powered by Google App Engine
This is Rietveld 408576698