Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: base/trace_event/trace_event_impl.cc

Issue 1539703002: [Tracing] Remove context_id in favor of traits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Undo some git cl format Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/trace_event_impl.h ('k') | base/trace_event/trace_log.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_event_impl.cc
diff --git a/base/trace_event/trace_event_impl.cc b/base/trace_event/trace_event_impl.cc
index 7e63f72e51b2224db78ae4285f4216cace330caf..b7f0f24f33f48c222f6074cbab7bbcaed473cf50 100644
--- a/base/trace_event/trace_event_impl.cc
+++ b/base/trace_event/trace_event_impl.cc
@@ -58,7 +58,6 @@ void TraceEvent::CopyFrom(const TraceEvent& other) {
thread_timestamp_ = other.thread_timestamp_;
duration_ = other.duration_;
id_ = other.id_;
- context_id_ = other.context_id_;
category_group_enabled_ = other.category_group_enabled_;
name_ = other.name_;
if (other.flags_ & TRACE_EVENT_FLAG_HAS_PROCESS_ID)
@@ -85,7 +84,6 @@ void TraceEvent::Initialize(
const unsigned char* category_group_enabled,
const char* name,
unsigned long long id,
- unsigned long long context_id,
unsigned long long bind_id,
int num_args,
const char** arg_names,
@@ -97,7 +95,6 @@ void TraceEvent::Initialize(
thread_timestamp_ = thread_timestamp;
duration_ = TimeDelta::FromInternalValue(-1);
id_ = id;
- context_id_ = context_id;
category_group_enabled_ = category_group_enabled;
name_ = name;
thread_id_ = thread_id;
@@ -371,11 +368,6 @@ void TraceEvent::AppendAsJSON(
if (flags_ & TRACE_EVENT_FLAG_FLOW_OUT)
StringAppendF(out, ",\"flow_out\":true");
- // Similar to id_, print the context_id as hex if present.
- if (flags_ & TRACE_EVENT_FLAG_HAS_CONTEXT_ID)
- StringAppendF(out, ",\"cid\":\"0x%" PRIx64 "\"",
- static_cast<uint64>(context_id_));
-
// Instant events also output their scope.
if (phase_ == TRACE_EVENT_PHASE_INSTANT) {
char scope = '?';
« no previous file with comments | « base/trace_event/trace_event_impl.h ('k') | base/trace_event/trace_log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698