Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1539563003: Remove unused fields in RawField from precompiled snapshot. (Closed)

Created:
5 years ago by Florian Schneider
Modified:
5 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unused fields in RawField from precompiled snapshot. This saves around 1% (25K for hello.dart, 75K for dart2js) from the precompiled isolate snapshot. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/978e7834ab080f99946548616aba67bd37a264ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
M runtime/vm/raw_object.h View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 3 chunks +24 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
5 years ago (2015-12-17 17:52:53 UTC) #2
rmacnak
LGTM
5 years ago (2015-12-17 18:00:30 UTC) #3
Florian Schneider
5 years ago (2015-12-17 19:42:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
978e7834ab080f99946548616aba67bd37a264ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698