Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 1539563003: Remove unused fields in RawField from precompiled snapshot. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object_snapshot.cc
diff --git a/runtime/vm/raw_object_snapshot.cc b/runtime/vm/raw_object_snapshot.cc
index 38e1f177ba984825a1f1673be793a73962894b1a..e9674e9f155547dab8f44cb1d6545305f817f86b 100644
--- a/runtime/vm/raw_object_snapshot.cc
+++ b/runtime/vm/raw_object_snapshot.cc
@@ -796,14 +796,23 @@ RawField* Field::ReadFrom(SnapshotReader* reader,
reader->AddBackRef(object_id, &field, kIsDeserialized);
// Set all non object fields.
- field.set_token_pos(reader->Read<int32_t>());
- field.set_guarded_cid(reader->Read<int32_t>());
- field.set_is_nullable(reader->Read<int32_t>());
+ if (reader->snapshot_code()) {
+ field.set_token_pos(0);
+ field.set_guarded_cid(kIllegalCid);
+ field.set_is_nullable(kIllegalCid);
+ } else {
+ field.set_token_pos(reader->Read<int32_t>());
+ field.set_guarded_cid(reader->Read<int32_t>());
+ field.set_is_nullable(reader->Read<int32_t>());
+ }
field.set_kind_bits(reader->Read<uint8_t>());
// Set all the object fields.
+ RawObject** toobj = reader->snapshot_code()
+ ? field.raw()->to_precompiled_snapshot()
+ : field.raw()->to();
READ_OBJECT_FIELDS(field,
- field.raw()->from(), field.raw()->to(),
+ field.raw()->from(), toobj,
kAsReference);
field.InitializeGuardedListLengthInObjectOffset();
@@ -827,9 +836,11 @@ void RawField::WriteTo(SnapshotWriter* writer,
writer->WriteTags(writer->GetObjectTags(this));
// Write out all the non object fields.
- writer->Write<int32_t>(ptr()->token_pos_);
- writer->Write<int32_t>(ptr()->guarded_cid_);
- writer->Write<int32_t>(ptr()->is_nullable_);
+ if (!writer->snapshot_code()) {
+ writer->Write<int32_t>(ptr()->token_pos_);
+ writer->Write<int32_t>(ptr()->guarded_cid_);
+ writer->Write<int32_t>(ptr()->is_nullable_);
+ }
writer->Write<uint8_t>(ptr()->kind_bits_);
// Write out the name.
@@ -851,16 +862,18 @@ void RawField::WriteTo(SnapshotWriter* writer,
} else {
writer->WriteObjectImpl(ptr()->value_.offset_, kAsReference);
}
- // Write out the dependent code.
- writer->WriteObjectImpl(ptr()->dependent_code_, kAsReference);
// Write out the initializer function or saved initial value.
if (writer->snapshot_code()) {
writer->WriteObjectImpl(ptr()->initializer_.precompiled_, kAsReference);
} else {
writer->WriteObjectImpl(ptr()->initializer_.saved_value_, kAsReference);
}
- // Write out the guarded list length.
- writer->WriteObjectImpl(ptr()->guarded_list_length_, kAsReference);
+ if (!writer->snapshot_code()) {
+ // Write out the dependent code.
+ writer->WriteObjectImpl(ptr()->dependent_code_, kAsReference);
+ // Write out the guarded list length.
+ writer->WriteObjectImpl(ptr()->guarded_list_length_, kAsReference);
+ }
}
« no previous file with comments | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698