Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 1539483002: [debugger] simplify stepping logic. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] simplify stepping logic. Now that we do not support arbitrary step count anymore, we can make this a lot easier. R=jkummerow@chromium.org Committed: https://crrev.com/67bd94508c0792171ae60d332c9cb2213e6a72fb Cr-Commit-Position: refs/heads/master@{#32966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -205 lines) Patch
M src/debug/debug.h View 4 chunks +7 lines, -18 lines 0 comments Download
M src/debug/debug.cc View 19 chunks +110 lines, -173 lines 0 comments Download
M src/debug/debug-scopes.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-observe.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
5 years ago (2015-12-17 13:15:25 UTC) #1
Jakob Kummerow
lgtm
5 years ago (2015-12-18 09:07:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539483002/1
5 years ago (2015-12-18 10:09:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 10:33:31 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-18 10:34:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67bd94508c0792171ae60d332c9cb2213e6a72fb
Cr-Commit-Position: refs/heads/master@{#32966}

Powered by Google App Engine
This is Rietveld 408576698