Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 1539483002: [debugger] simplify stepping logic. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug-scopes.cc ('k') | src/runtime/runtime-observe.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/debug/debug-evaluate.h" 9 #include "src/debug/debug-evaluate.h"
10 #include "src/debug/debug-frames.h" 10 #include "src/debug/debug-frames.h"
(...skipping 1213 matching lines...) Expand 10 before | Expand all | Expand 10 after
1224 StepAction step_action = static_cast<StepAction>(NumberToInt32(args[1])); 1224 StepAction step_action = static_cast<StepAction>(NumberToInt32(args[1]));
1225 if (step_action != StepIn && step_action != StepNext && 1225 if (step_action != StepIn && step_action != StepNext &&
1226 step_action != StepOut && step_action != StepFrame) { 1226 step_action != StepOut && step_action != StepFrame) {
1227 return isolate->Throw(isolate->heap()->illegal_argument_string()); 1227 return isolate->Throw(isolate->heap()->illegal_argument_string());
1228 } 1228 }
1229 1229
1230 // Clear all current stepping setup. 1230 // Clear all current stepping setup.
1231 isolate->debug()->ClearStepping(); 1231 isolate->debug()->ClearStepping();
1232 1232
1233 // Prepare step. 1233 // Prepare step.
1234 isolate->debug()->PrepareStep(static_cast<StepAction>(step_action), 1); 1234 isolate->debug()->PrepareStep(static_cast<StepAction>(step_action));
1235 return isolate->heap()->undefined_value(); 1235 return isolate->heap()->undefined_value();
1236 } 1236 }
1237 1237
1238 1238
1239 // Clear all stepping set by PrepareStep. 1239 // Clear all stepping set by PrepareStep.
1240 RUNTIME_FUNCTION(Runtime_ClearStepping) { 1240 RUNTIME_FUNCTION(Runtime_ClearStepping) {
1241 HandleScope scope(isolate); 1241 HandleScope scope(isolate);
1242 DCHECK(args.length() == 0); 1242 DCHECK(args.length() == 0);
1243 RUNTIME_ASSERT(isolate->debug()->is_active()); 1243 RUNTIME_ASSERT(isolate->debug()->is_active());
1244 isolate->debug()->ClearStepping(); 1244 isolate->debug()->ClearStepping();
(...skipping 435 matching lines...) Expand 10 before | Expand all | Expand 10 after
1680 return Smi::FromInt(isolate->debug()->is_active()); 1680 return Smi::FromInt(isolate->debug()->is_active());
1681 } 1681 }
1682 1682
1683 1683
1684 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) { 1684 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
1685 UNIMPLEMENTED(); 1685 UNIMPLEMENTED();
1686 return NULL; 1686 return NULL;
1687 } 1687 }
1688 } // namespace internal 1688 } // namespace internal
1689 } // namespace v8 1689 } // namespace v8
OLDNEW
« no previous file with comments | « src/debug/debug-scopes.cc ('k') | src/runtime/runtime-observe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698