Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1539133002: Oilpan: avoid heap allocation in MajorGCWrapperVisitor (Closed)

Created:
5 years ago by sof
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: avoid heap allocation in MajorGCWrapperVisitor The collection of retained object roots is preferably not allocated on the Oilpan heap as that risks triggering an unnecessary GC. R=haraken BUG= Committed: https://crrev.com/01198da4bd7764be04c5c7f4af124652ad72e9eb Cr-Commit-Position: refs/heads/master@{#367161}

Patch Set 1 #

Patch Set 2 : still support traverse-only DOMWrapperTracer invocations #

Total comments: 2

Patch Set 3 : add explanatory comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
sof
please take a look.
4 years, 11 months ago (2015-12-30 15:11:06 UTC) #3
haraken
LGTM https://codereview.chromium.org/1539133002/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right): https://codereview.chromium.org/1539133002/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp#newcode237 third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:237: Vector<RawPtrWillBeUntracedMember<Node>> m_groupsWhichNeedRetainerInfo; Maybe worth adding a comment to ...
4 years, 11 months ago (2015-12-30 16:00:15 UTC) #5
sof
https://codereview.chromium.org/1539133002/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right): https://codereview.chromium.org/1539133002/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp#newcode237 third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:237: Vector<RawPtrWillBeUntracedMember<Node>> m_groupsWhichNeedRetainerInfo; On 2015/12/30 16:00:14, haraken wrote: > > ...
4 years, 11 months ago (2015-12-30 16:08:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539133002/40001
4 years, 11 months ago (2015-12-30 16:08:18 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2015-12-30 17:37:46 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 17:39:25 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/01198da4bd7764be04c5c7f4af124652ad72e9eb
Cr-Commit-Position: refs/heads/master@{#367161}

Powered by Google App Engine
This is Rietveld 408576698