Oilpan: avoid heap allocation in MajorGCWrapperVisitor

Oilpan: avoid heap allocation in MajorGCWrapperVisitor

The collection of retained object roots is preferably not allocated on
the Oilpan heap as that risks triggering an unnecessary GC.

R=haraken
BUG=

Committed: https://crrev.com/01198da4bd7764be04c5c7f4af124652ad72e9eb
Cr-Commit-Position: refs/heads/master@{#367161}

[sof, 2015-12-30 15:10:38]

Description was changed from

==========
Oilpan: avoid heap allocation in MajorGCWrapperVisitor

The collection of retained object roots is preferably not allocated on
the Oilpan heap, as that risks triggering an unnecessary GC.

R=
BUG=
==========

to

==========
Oilpan: avoid heap allocation in MajorGCWrapperVisitor

The collection of retained object roots is preferably not allocated on
the Oilpan heap as that risks triggering an unnecessary GC.

R=
BUG=
==========

[sof, 2015-12-30 15:11:05]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-12-30 15:11:06]

please take a look.

[haraken, 2015-12-30 16:00:14]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-12-30 16:00:15]

LGTM

https://codereview.chromium.org/1539133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right):

https://codereview.chromium.org/1539133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:237:
Vector<RawPtrWillBeUntracedMember<Node>> m_groupsWhichNeedRetainerInfo;

Maybe worth adding a comment to explain why we need to use UntracedMembers.

[sof, 2015-12-30 16:07:06]

Description was changed from

==========
Oilpan: avoid heap allocation in MajorGCWrapperVisitor

The collection of retained object roots is preferably not allocated on
the Oilpan heap as that risks triggering an unnecessary GC.

R=
BUG=
==========

to

==========
Oilpan: avoid heap allocation in MajorGCWrapperVisitor

The collection of retained object roots is preferably not allocated on
the Oilpan heap as that risks triggering an unnecessary GC.

R=haraken
BUG=
==========

[sof, 2015-12-30 16:08:01]

https://codereview.chromium.org/1539133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right):

https://codereview.chromium.org/1539133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:237:
Vector<RawPtrWillBeUntracedMember<Node>> m_groupsWhichNeedRetainerInfo;
On 2015/12/30 16:00:14, haraken wrote:
> 
> Maybe worth adding a comment to explain why we need to use UntracedMembers.

added explanatory comment.

[sof, 2015-12-30 16:08:06]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-12-30 16:08:06]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1539133002/#ps40001
(title: "add explanatory comment")

[commit-bot: I haz the power, 2015-12-30 16:08:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1539133002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1539133002/40001

[commit-bot: I haz the power, 2015-12-30 17:37:45]

Description was changed from

==========
Oilpan: avoid heap allocation in MajorGCWrapperVisitor

The collection of retained object roots is preferably not allocated on
the Oilpan heap as that risks triggering an unnecessary GC.

R=haraken
BUG=
==========

to

==========
Oilpan: avoid heap allocation in MajorGCWrapperVisitor

The collection of retained object roots is preferably not allocated on
the Oilpan heap as that risks triggering an unnecessary GC.

R=haraken
BUG=
==========

[commit-bot: I haz the power, 2015-12-30 17:37:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-30 17:39:24]

Description was changed from

==========
Oilpan: avoid heap allocation in MajorGCWrapperVisitor

The collection of retained object roots is preferably not allocated on
the Oilpan heap as that risks triggering an unnecessary GC.

R=haraken
BUG=
==========

to

==========
Oilpan: avoid heap allocation in MajorGCWrapperVisitor

The collection of retained object roots is preferably not allocated on
the Oilpan heap as that risks triggering an unnecessary GC.

R=haraken
BUG=

Committed: https://crrev.com/01198da4bd7764be04c5c7f4af124652ad72e9eb
Cr-Commit-Position: refs/heads/master@{#367161}
==========

[commit-bot: I haz the power, 2015-12-30 17:39:25]

Patchset 3 (id:??) landed as
https://crrev.com/01198da4bd7764be04c5c7f4af124652ad72e9eb
Cr-Commit-Position: refs/heads/master@{#367161}